Skip to content

Commit e0dabcf

Browse files
author
Pavel Siska
committed
appFs - Initialize fuse_buf struct to avoid use of uninitialized values
Previously, m_buffer members were manually set in the constructor, but not all fields were guaranteed to be initialized, leading to valgrind warnings about uninitialized reads inside libfuse.
1 parent 603a1fd commit e0dabcf

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/appFs/appFs.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -365,8 +365,6 @@ class AppFsFuseBuffer {
365365
public:
366366
AppFsFuseBuffer()
367367
{
368-
m_buffer.mem = nullptr;
369-
m_buffer.size = 0;
370368
}
371369

372370
~AppFsFuseBuffer()
@@ -378,7 +376,7 @@ class AppFsFuseBuffer {
378376
fuse_buf* getBuffer() { return &m_buffer; }
379377

380378
private:
381-
fuse_buf m_buffer;
379+
fuse_buf m_buffer {};
382380
};
383381

384382
static void fuseLoop(struct fuse_session* session)

0 commit comments

Comments
 (0)