From ab04c0682d990d85762a2d8d9cefca7f4c625afd Mon Sep 17 00:00:00 2001 From: Jiefu Ling <74678923+Jeff-Ling@users.noreply.github.com> Date: Wed, 20 Sep 2023 11:42:05 -0400 Subject: [PATCH 1/3] Update README.md --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index aa0f112..32c1739 100644 --- a/README.md +++ b/README.md @@ -17,3 +17,11 @@ Extra credit if you can find all FIVE bugs. - In the README, create a link to your shader toy solution with the bugs corrected - In the README, describe each bug you found and include a sentence about HOW you found it. - Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!) + +# Jiefu Ling Updated +- Team members: Jiefu Ling, Alex Fu +- [Link to solution](https://www.shadertoy.com/view/cd3yR2) +- Bugs: 1. vec uv2. It missed the 2 after vec2. I found this error through the compiler error. +- 2. H *= len * iResolution.x / iResolution.x; It should be H *= len * iResolution.x / iResolution.y; I found this error by checking line by line. Aspect should be x / y not x / x; +- 3. raycast(uv, dir, eye, ref); It should be raycast(uv2, dir, eye, ref); I found this error by checking through the main process of the shader. +- 4. dir = reflect(eye, nor); It should be dir = reflect(dir, nor); Because the reflection seems not correct. From da638cf5333ca3e3b01725a85b30bfba8a0b02e5 Mon Sep 17 00:00:00 2001 From: Jiefu Ling <74678923+Jeff-Ling@users.noreply.github.com> Date: Wed, 20 Sep 2023 11:42:46 -0400 Subject: [PATCH 2/3] Update README.md --- README.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 32c1739..d2159ef 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,8 @@ Extra credit if you can find all FIVE bugs. # Jiefu Ling Updated - Team members: Jiefu Ling, Alex Fu - [Link to solution](https://www.shadertoy.com/view/cd3yR2) -- Bugs: 1. vec uv2. It missed the 2 after vec2. I found this error through the compiler error. -- 2. H *= len * iResolution.x / iResolution.x; It should be H *= len * iResolution.x / iResolution.y; I found this error by checking line by line. Aspect should be x / y not x / x; -- 3. raycast(uv, dir, eye, ref); It should be raycast(uv2, dir, eye, ref); I found this error by checking through the main process of the shader. -- 4. dir = reflect(eye, nor); It should be dir = reflect(dir, nor); Because the reflection seems not correct. +- Bugs: + 1. vec uv2. It missed the 2 after vec2. I found this error through the compiler error. + 2. H *= len * iResolution.x / iResolution.x; It should be H *= len * iResolution.x / iResolution.y; I found this error by checking line by line. Aspect should be x / y not x / x; + 3. raycast(uv, dir, eye, ref); It should be raycast(uv2, dir, eye, ref); I found this error by checking through the main process of the shader. + 4. dir = reflect(eye, nor); It should be dir = reflect(dir, nor); Because the reflection seems not correct. From 0e13171a864edea3be4628b16358bd3562932737 Mon Sep 17 00:00:00 2001 From: Jiefu Ling <74678923+Jeff-Ling@users.noreply.github.com> Date: Wed, 20 Sep 2023 11:44:16 -0400 Subject: [PATCH 3/3] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d2159ef..ff411b0 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ Extra credit if you can find all FIVE bugs. - In the README, describe each bug you found and include a sentence about HOW you found it. - Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!) -# Jiefu Ling Updated +# Jiefu Ling & Alex Fu - Team members: Jiefu Ling, Alex Fu - [Link to solution](https://www.shadertoy.com/view/cd3yR2) - Bugs: