refactor: extract plugin_get_rows_per_page helper to DRY filter boilerplate

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Author: somethingwithproof

notify_lists.php

@@ -1047,11 +1047,7 @@ function hosts($header_label) {
 	// ================= input validation =================
 
 	// if the number of rows is -1, set it to the default
-	if (get_request_var('rows') == -1) {
-		$rows = read_config_option('num_rows_table');
-	} else {
-		$rows = get_request_var('rows');
-	}
+	$rows = plugin_get_rows_per_page();
 
 	html_start_box(__('Associated Devices', 'thold') . ' ' . html_escape($header_label), '100%', false, '3', 'center', '');
 
@@ -1375,11 +1371,7 @@ function tholds($header_label) {
 	}
 
 	// if the number of rows is -1, set it to the default
-	if (get_request_var('rows') == -1) {
-		$rows = read_config_option('num_rows_table');
-	} else {
-		$rows = get_request_var('rows');
-	}
+	$rows = plugin_get_rows_per_page();
 
 	$sql_where = '';
 
@@ -1724,11 +1716,7 @@ function templates($header_label) {
 	thold_template_request_validation();
 
 	// if the number of rows is -1, set it to the default
-	if (get_request_var('rows') == -1) {
-		$rows = read_config_option('num_rows_table');
-	} else {
-		$rows = get_request_var('rows');
-	}
+	$rows = plugin_get_rows_per_page();
 
 	$sql_where = '';
 	$sql_order = get_order_string();
@@ -2069,11 +2057,7 @@ function lists() {
 	// ================= input validation =================
 
 	// if the number of rows is -1, set it to the default
-	if (get_request_var('rows') == -1) {
-		$rows = read_config_option('num_rows_table');
-	} else {
-		$rows = get_request_var('rows');
-	}
+	$rows = plugin_get_rows_per_page();
 
 	html_start_box(__('Notification Lists', 'thold'), '100%', false, '3', 'center', 'notify_lists.php?action=edit');
 

thold.php

@@ -585,11 +585,7 @@ function list_tholds() {
 	include($config['base_path'] . '/plugins/thold/includes/arrays.php');
 
 	// if the number of rows is -1, set it to the default
-	if (get_request_var('rows') == -1) {
-		$rows = read_config_option('num_rows_table');
-	} else {
-		$rows = get_request_var('rows');
-	}
+	$rows = plugin_get_rows_per_page();
 
 	top_header();
 

thold_functions.php

@@ -54,6 +54,25 @@
  *
  * @return - the sanitized search string
  */
+
+/**
+ * plugin_get_rows_per_page - resolve rows-per-page from request vars
+ *
+ * @return int
+ */
+function plugin_get_rows_per_page() {
+	$rows = get_request_var('rows');
+
+	if ($rows == -1) {
+		return read_config_option('num_rows_table');
+	} elseif ($rows == -2) {
+		return 999999;
+	}
+
+	return $rows;
+}
+
+
 function sanitize_thold_sort_string($string) {
 	static $drop_char_match   = ['^', '$', '<', '>', '`', '\'', '"', '|', '?', '+', '[', ']', '{', '}', '#', ';', '!', '=', '*'];
 	static $drop_char_replace = [' ', ' ', ' ', ' ', '', '', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '];

thold_graph.php

@@ -922,11 +922,7 @@ function hosts() {
 	// ================= input validation =================
 
 	// if the number of rows is -1, set it to the default
-	if (get_request_var('rows') == -1) {
-		$rows = read_config_option('num_rows_table');
-	} else {
-		$rows = get_request_var('rows');
-	}
+	$rows = plugin_get_rows_per_page();
 
 	html_start_box(__('Device Status', 'thold'), '100%', false, '3', 'center', '');
 	form_host_filter();
@@ -1426,11 +1422,7 @@ function thold_show_log() {
 	thold_validate_log_vars();
 
 	// if the number of rows is -1, set it to the default
-	if (get_request_var('rows') == -1) {
-		$rows = read_config_option('num_rows_table');
-	} else {
-		$rows = get_request_var('rows');
-	}
+	$rows = plugin_get_rows_per_page();
 
 	$days = read_config_option('thold_log_storage');
 

thold_templates.php

@@ -2133,11 +2133,7 @@ function templates() {
 	template_request_validation();
 
 	// if the number of rows is -1, set it to the default
-	if (get_request_var('rows') == -1) {
-		$rows = read_config_option('num_rows_table');
-	} else {
-		$rows = get_request_var('rows');
-	}
+	$rows = plugin_get_rows_per_page();
 
 	html_start_box(__('Threshold Templates', 'thold'), '100%', false, '3', 'center', 'thold_templates.php?action=add');