diff --git a/backend/controllers/achievementController.js b/backend/controllers/achievementController.js index ca7af002..9d0845f0 100644 --- a/backend/controllers/achievementController.js +++ b/backend/controllers/achievementController.js @@ -20,13 +20,17 @@ exports.getAchievements = async (req, res) => { exports.saveAchievements = async (req, res) => { const { unlockedAchievements } = req.body; - if (!unlockedAchievements || !Array.isArray(unlockedAchievements)) { + if (!unlockedAchievements || !Array.isArray(unlockedAchievements)) { return res.status(400).json({ success: false, error: "unlockedAchievements must be a valid array" }); } + if (unlockedAchievements.length === 0) { + return res.json({ success: true }); + } + const unknown = unlockedAchievements.filter((id) => !VALID_ACHIEVEMENTS.has(id)); if (unknown.length > 0) { @@ -37,12 +41,15 @@ exports.saveAchievements = async (req, res) => { } try { - await User.findByIdAndUpdate( + const user = await User.findByIdAndUpdate( req.user._id, { $addToSet: { unlockedAchievements: { $each: unlockedAchievements } } }, ); + if (!user) { + return res.status(404).json({ success: false, error: "User not found" }); + } res.json({ success: true }); } catch (err) { res.status(500).json({ success: false, error: "A server error occurred" }); } -}; \ No newline at end of file +}; diff --git a/backend/tests/achievementController.unit.test.js b/backend/tests/achievementController.unit.test.js index c831a906..a260ac60 100644 --- a/backend/tests/achievementController.unit.test.js +++ b/backend/tests/achievementController.unit.test.js @@ -135,6 +135,28 @@ describe('achievementController', () => { }); }); + it('handles empty unlockedAchievements array as a successful no-op without calling findByIdAndUpdate', async () => { + const req = makeReq({ unlockedAchievements: [] }); + const res = makeRes(); + + await saveAchievements(req, res); + + expect(User.findByIdAndUpdate).not.toHaveBeenCalled(); + expect(res.json).toHaveBeenCalledWith({ success: true }); + }); + + it('returns 404 if user is not found during save', async () => { + User.findByIdAndUpdate.mockResolvedValue(null); + + const req = makeReq({ unlockedAchievements: ['First Interview'] }); + const res = makeRes(); + + await saveAchievements(req, res); + + expect(res.status).toHaveBeenCalledWith(404); + expect(res.json).toHaveBeenCalledWith({ success: false, error: 'User not found' }); + }); + it('successfully saves achievements for a valid request', async () => { User.findByIdAndUpdate.mockResolvedValue({});