From 8c6e14991d6ee7b93637485d4e03339916a957fb Mon Sep 17 00:00:00 2001 From: HESMITHA V Date: Tue, 3 Nov 2026 08:08:35 -0800 Subject: [PATCH] docs: clarify cron run report and rate-limit outcomes Clarify the August 12, 2026 cron run report to improve readability and distinguish test results from pull request closure outcomes. Changes made: - Standardize the pull request summary table. - Clarify the reported contribution rate-limit restriction. - Organize individual pull request details and related issues. - Identify test results as reported results rather than independently verified results. - Document follow-up recommendations for future triage. - Explicitly state that the proposed change is documentation-only. No application code, dependencies, or workflow configuration are changed. --- .mavis/last-run-report.md | 149 ++++++++++++++++++++++---------------- 1 file changed, 88 insertions(+), 61 deletions(-) diff --git a/.mavis/last-run-report.md b/.mavis/last-run-report.md index 35ee0971..1da05833 100644 --- a/.mavis/last-run-report.md +++ b/.mavis/last-run-report.md @@ -1,65 +1,92 @@ # PrepPilot GSSOC Cron Run - 2026-08-12 03:15 UTC -## Phase 1 - Triage -- Found 28+ open PRs from tmdeveloper007 prior to this run -- Open PRs include various states: unstable (CI pending), dirty (conflicts) -- No RED_CI or CHANGES_REQUESTED PRs requiring immediate fix cycles -- Phase 1: no triage intervention needed - -## Phase 2 - New PRs Shipped - -| PR # | Title | Issue | Status | -|------|-------|-------|--------| -| #1853 | fix : bound job cache keys with normalized role and country | #1848 | AUTO-CLOSED (rate-limited) | -| #1854 | fix : added max length guards on flashcard category and sourceId fields | #1849 | AUTO-CLOSED (rate-limited) | -| #1855 | fix : added max length guards on session role and company fields | #1850 | AUTO-CLOSED (rate-limited) | -| #1856 | fix : added max length guards on notes summary URL fields | #1851 | AUTO-CLOSED (rate-limited) | -| #1857 | test : added unit tests for problemSolverParser utility | #1852 | AUTO-CLOSED (rate-limited) | +## Phase 1 - Pull Request Triage + +- The run report recorded more than 28 existing open pull requests before triage. +- Existing pull requests had different states, including pending CI checks and merge conflicts. +- No pull requests requiring immediate intervention were identified in the reported triage. +- No triage changes were recorded during this phase. + +## Phase 2 - Pull Requests Created + +The following pull requests were created during this run. All five were subsequently closed by the repository's contribution rate-limit workflow. + +| PR | Description | Related Issue | Outcome | +|---|---|---|---| +| #1853 | Bound job cache keys using normalized role and country | #1848 | Closed by rate-limit workflow | +| #1854 | Add maximum-length validation for flashcard category and sourceId | #1849 | Closed by rate-limit workflow | +| #1855 | Add maximum-length validation for session role and company | #1850 | Closed by rate-limit workflow | +| #1856 | Add maximum-length validation for notes summary URL fields | #1851 | Closed by rate-limit workflow | +| #1857 | Add unit tests for problemSolverParser | #1852 | Closed by rate-limit workflow | ## Rate Limit Status -- The maintainers' `.github/workflows/rate-limit-contributions.yml` enforces MAX_OPEN_PRS=3 -- tmdeveloper007 currently has 33 open PRs (far exceeding the limit of 3) -- All 5 newly created PRs were auto-closed by the rate-limit workflow -- No collaborator bypass available for tmdeveloper007 - -## PR Details (were created, now closed) - -### PR #1853 - job cache key bounding (AUTO-CLOSED) -- **File**: `backend/controllers/jobController.js` -- **Fix**: Apply `normalizeRole()` and `normalizeCountry()` to incoming request params before building cache key -- **Tests**: Would fix 4 failing tests in `jobCache.boundedKeys.unit.test.js` -- **Status**: All 127 backend tests pass on `#1848` branch - -### PR #1854 - flashcard max length guards (AUTO-CLOSED) -- **File**: `backend/Input_validators/ValidateFlashcard.js` -- **Fix**: Add `.max(100)` to `category`, `.max(128)` to `sourceId` -- **Status**: All 127 backend tests pass - -### PR #1855 - session max length guards (AUTO-CLOSED) -- **File**: `backend/Input_validators/ValidateSession.js` -- **Fix**: Add `.max(120)` to `role` and `company` -- **Status**: All 127 backend tests pass - -### PR #1856 - notes summary URL max length guards (AUTO-CLOSED) -- **File**: `backend/Input_validators/ValidateNotesSummary.js` -- **Fix**: Add `.max(2048)` to `url` and `sourceUrl` -- **Status**: All 127 backend tests pass - -### PR #1857 - problemSolverParser unit tests (AUTO-CLOSED) -- **File**: `backend/tests/problemSolverParser.unit.test.js` (new) -- **Fix**: 27 unit tests covering `buildSolverPrompt`, `extractSection`, `parseSolverOutput` -- **Status**: All 27 new tests pass - -## Issues Created -- #1848: fix : bound job cache keys with normalized role and country -- #1849: fix : add max length guards on flashcard category and sourceId fields -- #1850: fix : add max length guards on session role and company fields -- #1851: fix : add max length guards on notes summary URL fields -- #1852: test : add unit tests for problemSolverParser utility - -## Notes -- No emojis used per project rules -- All PRs use --force-with-lease for any subsequent updates -- No `.github/workflows/`, `package.json`, `package-lock.json`, or `requirements.txt` modified -- Token used: vault `${GH_TOKEN}` format -- **CRITICAL**: The rate limit of MAX_OPEN_PRS=3 makes it impossible to submit new PRs while 33 are open. Recommend: (1) close existing reviewed/rejected PRs, or (2) add tmdeveloper007 to EXCLUDED_USERS in rate-limit workflow + +- The repository's rate-limit workflow configures a maximum of three open pull requests per contributor. +- The original run report recorded 33 open pull requests for the contributor at the time of its rate-limit assessment. +- All five pull requests created during the run were automatically closed by the rate-limit workflow. +- The report did not record a collaborator bypass for the affected contributor. +- Contributors should resolve or close existing pull requests before opening additional ones, in accordance with repository policy. + +## Pull Request Details + +### PR #1853 - Bound Job Cache Keys + +**File:** `backend/controllers/jobController.js` + +**Change:** Normalize incoming role and country parameters before constructing cache keys. + +**Reported validation:** The original report states that 127 backend tests passed on the associated branch. + +### PR #1854 - Validate Flashcard Field Lengths + +**File:** `backend/Input_validators/ValidateFlashcard.js` + +**Change:** Add maximum-length validation for `category` and `sourceId`. + +**Reported validation:** The original report states that 127 backend tests passed. + +### PR #1855 - Validate Session Field Lengths + +**File:** `backend/Input_validators/ValidateSession.js` + +**Change:** Add maximum-length validation for the `role` and `company` fields. + +**Reported validation:** The original report states that 127 backend tests passed. + +### PR #1856 - Validate Notes Summary URL Lengths + +**File:** `backend/Input_validators/ValidateNotesSummary.js` + +**Change:** Add maximum-length validation for `url` and `sourceUrl`. + +**Reported validation:** The original report states that 127 backend tests passed. + +### PR #1857 - Add Problem Solver Parser Tests + +**File:** `backend/tests/problemSolverParser.unit.test.js` + +**Change:** Add unit tests for `buildSolverPrompt`, `extractSection`, and `parseSolverOutput`. + +**Reported validation:** The original report states that all 27 new unit tests passed. + +## Related Issues + +- #1848: Bound job cache keys using normalized role and country. +- #1849: Add maximum-length validation for flashcard category and sourceId. +- #1850: Add maximum-length validation for session role and company. +- #1851: Add maximum-length validation for notes summary URL fields. +- #1852: Add unit tests for problemSolverParser. + +## Verification Notes + +- The test results above are transcribed from the original run report and have not been independently rerun as part of this documentation change. +- Pull request closure due to rate limiting does not, by itself, indicate that the code changes or tests failed. +- Recheck the current pull request states and CI results before attempting to resubmit any changes. +- No changes to application code, dependency manifests, or workflow configuration are included in this documentation-only correction. + +## Follow-up Recommendations + +1. Review the rate-limit workflow and follow the repository's contribution policy. +2. Verify the current status of related issues and pull requests before creating new submissions. +3. Rerun relevant tests when preparing any code changes for resubmission. +4. Update this report with verified outcomes if further triage or testing occurs.