-
Notifications
You must be signed in to change notification settings - Fork 81
Open
Description
Context:
- Currently upgrading to SDK v0.50 feat: bump up cosmos-sdk v0.50.x, cometbft v0.38.x b-harvest/Canto#53
- Discrepancies found in
BlockedAddrsbetween v0.50 simapp and Canto's implementation during upgrade.
Differences and Suggestions:
- Gov Module Account:
- v0.50 simapp allows token receiving in gov module account, not blocked in
BlockedAddrs, unlike Canto. - This change was due to a refactor!: Refactor CommunityPoolSpendProposal cosmos/cosmos-sdk#12852 aiming to handle CommunityPool -> IBC transfer via gov module account.
- Suggestion: If no similar case is planned in Canto, keeping gov module in
BlockedAddrsmight minimize potential risks.
- v0.50 simapp allows token receiving in gov module account, not blocked in
- Distribution Module Account:
- v0.50 simapp disallows token receiving in distribution module account, but Canto currently allows it.
- This was an exception from Canto's initial setup, with unclear intent.
- Suggestion: Blocking the distribution module account in
BlockedAddrsto minimize risks unless there's an unidentified reason to allow it.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels