[Bug] Study Sessions Lack Duration Validation - Negative/Invalid Durations Accepted

[anshul23102]

Description

Study sessions lack duration validation. Users can create sessions with invalid durations (negative time, zero duration, extremely long sessions). No input validation prevents nonsensical values.

Steps to Reproduce

1. User creates study session
2. Sets duration to -2 hours or 0 hours
3. No validation error shown
4. Invalid session created
5. Tracking becomes meaningless

Environment Information

• Session creation: Form-based input
• Validation: Client-side only
• Duration field: Text or number input
• Constraints: None enforced

Expected Behavior

• Duration validated before saving
• Must be positive number
• Maximum reasonable duration (e.g., 12 hours)
• Minimum duration (e.g., 5 minutes)
• Error message on invalid input

Actual Behavior

• No validation
• Negative or zero durations accepted
• Invalid sessions created
• Tracking data corrupted

Code Reference

• File: src/forms/SessionForm.jsx
• Method: validateDuration() - missing or ineffective
• Missing: Input constraints
• Missing: Error feedback

Additional Context

This is a Level 2 data quality issue. Fix requires:

• Adding duration validation rules
• Range checking (5 minutes to 12 hours)
• Error messaging
• Server-side validation

Suggested Labels

bug, validation, data-quality, form-validation, error-handling

[rutul2006]

Hey @anshul23102 and the GSSoC Team!

I'd like to work on this issue as a part of GSSoC! This is an important data quality bug that directly impacts the reliability of study tracking, analytics, and goal progress.

Why this matters:

• Data Integrity: Invalid durations like 0, negative, or excessively long sessions can skew user statistics, streaks, and progress charts, making insights meaningless.
• Improved User Experience: Clear error messages and input constraints will guide users to enter realistic session durations, reducing confusion and frustration.
• Robustness: Implementing both client and server-side validation prevents data corruption, even if the form is bypassed.
• Trustworthy Tracking: Ensures the app provides accurate metrics, which is essential for user motivation and long-term engagement.

Proposed Solution:

• Client-Side Validation: Update src/forms/SessionForm.jsx to implement a robust validateDuration() function with clear rules (minimum 5 minutes, maximum 12 hours, and must be a positive number).
• Enhanced Input Constraints: Use appropriate input types (number) with min, max, and step attributes, along with real-time inline error messaging to prevent form submission until valid.
• Server-Side Validation: Add validation checks on the session creation/update API endpoints to reject invalid durations, ensuring data consistency across all sources.
• Edge Case Handling: Account for decimal values, unit conversions (minutes/hours), and sanitize inputs to prevent unexpected formats.
• Testing: Write unit tests for the validation logic and integration tests for the form and API to prevent regressions.
• User-Friendly Feedback: Display clear, actionable error messages (e.g., "Duration must be between 5 minutes and 12 hours.") to guide users.

I'd be happy to discuss the exact duration thresholds or any existing validation patterns in the codebase before getting started!

Could you please assign this issue to me? I'm excited to fix this and improve the overall quality of the application!

Thank you!