fix(web-pet): align i18n namespace and restore lifecycle test

Author: ChesterRa

tests/test_group_lifecycle_ops.py

@@ -57,7 +57,7 @@ def test_group_start_does_not_resume_paused_group(self) -> None:
                     "actor_id": "peer1",
                     "title": "Peer 1",
                     "runtime": "codex",
-                    "runner": "pty",
+                    "runner": "headless",
                     "by": "user",
                 },
             )

web/src/features/webPet/PetPanel.tsx

@@ -24,7 +24,7 @@ function countAgentsByState(panelData: PanelData) {
 }
 
 export function PetPanel({ panelData, align = "left", onClose, onAction, catSize = 80 }: PetPanelProps) {
-  const { t } = useTranslation("modals");
+  const { t } = useTranslation("webPet");
   const counts = countAgentsByState(panelData);
   const actionItems = panelData.actionItems.slice(0, 3);
 
@@ -49,7 +49,7 @@ export function PetPanel({ panelData, align = "left", onClose, onAction, catSize
         maxHeight: "calc(100vh - 48px)",
         ...horizontalStyle,
       }}
-      aria-label={t("webPet.panelAria", { defaultValue: "Web Pet panel" })}
+      aria-label={t("panelAria", { defaultValue: "Web Pet panel" })}
     >
       <div className="flex max-h-[inherit] flex-col overflow-hidden rounded-2xl">
         <div className="shrink-0 border-b border-[var(--glass-border-subtle)] px-4 py-3">
@@ -75,7 +75,7 @@ export function PetPanel({ panelData, align = "left", onClose, onAction, catSize
                 type="button"
                 className="flex h-7 w-7 shrink-0 items-center justify-center rounded-lg text-sm text-[var(--color-text-secondary)] transition hover:bg-white/10 hover:text-[var(--color-text-primary)]"
                 onClick={onClose}
-                aria-label={t("webPet.closePanelAria", { defaultValue: "Close panel" })}
+                aria-label={t("closePanelAria", { defaultValue: "Close panel" })}
               >
                 ×
               </button>
@@ -85,15 +85,15 @@ export function PetPanel({ panelData, align = "left", onClose, onAction, catSize
             <div className="mt-3">
               <div className="flex items-center justify-between text-[11px] text-[var(--color-text-secondary)]">
                 <span>
-                  {t("webPet.taskProgress", {
+                  {t("taskProgress", {
                     defaultValue: "{{done}}/{{total}} done",
                     done: panelData.taskProgress.done,
                     total: panelData.taskProgress.total,
                   })}
                 </span>
                 {panelData.taskProgress.active > 0 ? (
                   <span>
-                    {t("webPet.taskActive", {
+                    {t("taskActive", {
                       defaultValue: "{{count}} active",
                       count: panelData.taskProgress.active,
                     })}
@@ -112,19 +112,19 @@ export function PetPanel({ panelData, align = "left", onClose, onAction, catSize
           ) : null}
           <div className="mt-3 flex flex-wrap gap-2">
             <span className={countPillClass}>
-              {t("webPet.countWorking", {
+              {t("countWorking", {
                 defaultValue: "{{count}} working",
                 count: counts.working,
               })}
             </span>
             <span className={countPillClass}>
-              {t("webPet.countBusy", {
+              {t("countBusy", {
                 defaultValue: "{{count}} busy",
                 count: counts.busy,
               })}
             </span>
             <span className={countPillClass}>
-              {t("webPet.countNeedsYou", {
+              {t("countNeedsYou", {
                 defaultValue: "{{count}} needs you",
                 count: counts.needsYou,
               })}
@@ -167,8 +167,8 @@ export function PetPanel({ panelData, align = "left", onClose, onAction, catSize
                       {clickable ? (
                         <span className="text-[10px] text-[var(--color-text-secondary)] opacity-60">
                           {item.action!.type === "open_task"
-                            ? t("webPet.actionView", { defaultValue: "View" })
-                            : t("webPet.actionReply", { defaultValue: "Reply" })}
+                            ? t("action.view", { defaultValue: "View" })
+                            : t("action.reply", { defaultValue: "Reply" })}
                           {" →"}
                         </span>
                       ) : null}
@@ -182,7 +182,7 @@ export function PetPanel({ panelData, align = "left", onClose, onAction, catSize
             </div>
           ) : (
             <div className="rounded-xl border border-dashed border-[var(--glass-border-subtle)] px-3 py-4 text-sm text-[var(--color-text-secondary)]">
-              {t("webPet.noActionItems", {
+              {t("noActionItems", {
                 defaultValue: "No action items right now.",
               })}
             </div>

web/src/features/webPet/PetReminderBubble.tsx

@@ -18,25 +18,25 @@ function getActionButtons(
 
   if (reminder.kind === "waiting_user" && reminder.source.taskId) {
     buttons.push({
-      label: String(t("webPet.action.complete" as never, { defaultValue: "Done" } as never)),
+      label: String(t("action.complete", { defaultValue: "Done" })),
       action: {
         type: "complete_task",
         groupId: reminder.action.groupId,
         taskId: reminder.source.taskId,
       },
     });
     buttons.push({
-      label: String(t("webPet.action.view" as never, { defaultValue: "View" } as never)),
+      label: String(t("action.view", { defaultValue: "View" })),
       action: reminder.action,
     });
   } else if (reminder.kind === "reply_required") {
     buttons.push({
-      label: String(t("webPet.action.reply" as never, { defaultValue: "Reply" } as never)),
+      label: String(t("action.reply", { defaultValue: "Reply" })),
       action: reminder.action,
     });
   } else {
     buttons.push({
-      label: String(t("webPet.action.view" as never, { defaultValue: "View" } as never)),
+      label: String(t("action.view", { defaultValue: "View" })),
       action: reminder.action,
     });
   }
@@ -49,7 +49,7 @@ export function PetReminderBubble({
   onDismiss,
   onAction,
 }: PetReminderBubbleProps) {
-  const { t } = useTranslation("modals");
+  const { t } = useTranslation("webPet");
   const autoHideTimeoutRef = useRef<number | null>(null);
 
   const clearAutoHideTimer = useCallback(() => {
@@ -92,7 +92,7 @@ export function PetReminderBubble({
   );
 
   const displayAgent = reminder?.agent === "system"
-    ? t("webPet.systemAgent", { defaultValue: "System" })
+    ? t("systemAgent", { defaultValue: "System" })
     : reminder?.agent || "";
 
   const label = useMemo(() => {
@@ -112,9 +112,9 @@ export function PetReminderBubble({
   }
 
   const kindLabel = String(
-    t(`webPet.kind.${reminder.kind}` as never, {
+    t(`kind.${reminder.kind}`, {
       defaultValue: reminder.kind.replace(/_/g, " "),
-    } as never),
+    }),
   );
 
   return (
@@ -175,7 +175,7 @@ export function PetReminderBubble({
               event.stopPropagation();
               handleDismiss();
             }}
-            aria-label={t("webPet.dismissReminderAria", {
+            aria-label={t("dismissReminderAria", {
               defaultValue: "Dismiss reminder",
             })}
           >

web/src/features/webPet/WebPetBubble.tsx

@@ -19,7 +19,7 @@ export function WebPetBubble({
   panelOpen,
   onTogglePanel,
 }: WebPetBubbleProps) {
-  const { t } = useTranslation("modals");
+  const { t } = useTranslation("webPet");
   const { isDragging, handlers } = useWebPetDrag();
 
   return (
@@ -39,11 +39,11 @@ export function WebPetBubble({
       aria-expanded={panelOpen}
       aria-label={
         hint
-          ? t("webPet.bubbleAriaHint", {
+          ? t("bubbleAriaHint", {
               defaultValue: "Web Pet. {{hint}}",
               hint,
             })
-          : t("webPet.bubbleAria", { defaultValue: "Web Pet" })
+          : t("bubbleAria", { defaultValue: "Web Pet" })
       }
       onKeyDown={(event) => {
         if (event.key !== "Enter" && event.key !== " ") return;

web/src/features/webPet/useWebPetData.ts

@@ -10,12 +10,12 @@ function localizeConnectionMessage(
   tr: (key: string, fallback: string, vars?: Record<string, unknown>) => string,
 ): string {
   if (sseStatus === "connected") {
-    return tr("webPet.connection.connected", "Connected");
+    return tr("connection.connected", "Connected");
   }
   if (sseStatus === "connecting") {
-    return tr("webPet.connection.connecting", "Connecting…");
+    return tr("connection.connecting", "Connecting…");
   }
-  return tr("webPet.connection.disconnected", "Disconnected");
+  return tr("connection.disconnected", "Disconnected");
 }
 
 function localizeReminder(
@@ -24,29 +24,29 @@ function localizeReminder(
 ): PetReminder {
   const agentLabel =
     reminder.agent === "system"
-      ? tr("webPet.systemAgent", "System")
+      ? tr("systemAgent", "System")
       : reminder.agent;
 
   let summary = reminder.summary;
   if (reminder.kind === "stalled_peer") {
     summary = tr(
-      "webPet.reminderSummary.stalledPeer",
+      "reminderSummary.stalledPeer",
       "{{actor}} has been idle for a while on {{taskId}}.",
       {
         actor: reminder.source.actorId || agentLabel,
-        taskId: reminder.source.taskId || tr("webPet.taskFallback", "this task"),
+        taskId: reminder.source.taskId || tr("taskFallback", "this task"),
       },
     );
   } else if (!summary.trim()) {
     if (reminder.kind === "mention") {
       summary = tr(
-        "webPet.reminderSummary.mention",
+        "reminderSummary.mention",
         "{{actor}} mentioned you.",
         { actor: agentLabel },
       );
     } else if (reminder.kind === "reply_required") {
       summary = tr(
-        "webPet.reminderSummary.replyRequired",
+        "reminderSummary.replyRequired",
         "{{actor}} is waiting for your reply.",
         { actor: agentLabel },
       );
@@ -68,12 +68,12 @@ function localizePanelData(
     ...panelData,
     teamName:
       panelData.teamName.trim() ||
-      tr("webPet.teamFallback", "Team"),
+      tr("teamFallback", "Team"),
     actionItems: panelData.actionItems.map((item) => ({
       ...item,
       agent:
         item.agent === "system"
-          ? tr("webPet.systemAgent", "System")
+          ? tr("systemAgent", "System")
           : item.agent,
     })),
     connection: {
@@ -84,7 +84,7 @@ function localizePanelData(
 }
 
 export function useWebPetData() {
-  const { t } = useTranslation("modals");
+  const { t } = useTranslation("webPet");
   const selectedGroupId = useGroupStore((state) => state.selectedGroupId);
   const groupContext = useGroupStore((state) => state.groupContext);
   const groupDocTitle = useGroupStore((state) => state.groupDoc?.title ?? "");
@@ -94,7 +94,7 @@ export function useWebPetData() {
   const { reminders, activeReminder, reaction, dismissReminder } =
     useWebPetNotifications();
   const tr = (key: string, fallback: string, vars?: Record<string, unknown>) =>
-    String(t(key as never, { defaultValue: fallback, ...(vars || {}) } as never));
+    String(t(key, { defaultValue: fallback, ...(vars || {}) }));
 
   return useMemo(() => {
     const { catState, panelData: rawPanelData } = aggregateWebPetState({
@@ -127,12 +127,12 @@ export function useWebPetData() {
       const needsYouCount = localizedPanelData.actionItems.length;
       hint = needsYouCount > 0
         ? tr(
-            "webPet.hintTaskWithAction",
+            "hintTaskWithAction",
             "{{done}}/{{total}} done, {{count}} need you",
             { done, total, count: needsYouCount },
           )
         : tr(
-            "webPet.hintTaskProgress",
+            "hintTaskProgress",
             "{{done}}/{{total}} tasks done",
             { done, total },
           );

web/src/i18n/locales/en/modals.json

@@ -352,35 +352,5 @@
     "agents": "Agents",
     "tasks": "Tasks",
     "direction": "Direction"
-  },
-  "webPet": {
-    "panelAria": "Web Pet panel",
-    "closePanelAria": "Close panel",
-    "dismissReminderAria": "Dismiss reminder",
-    "bubbleAria": "Web Pet",
-    "bubbleAriaHint": "Web Pet. {{hint}}",
-    "teamFallback": "Team",
-    "systemAgent": "System",
-    "taskFallback": "this task",
-    "connection": {
-      "connected": "Connected",
-      "connecting": "Connecting…",
-      "disconnected": "Disconnected"
-    },
-    "countWorking": "{{count}} working",
-    "countBusy": "{{count}} busy",
-    "countNeedsYou": "{{count}} needs you",
-    "noActionItems": "No action items right now.",
-    "kind": {
-      "waiting_user": "waiting user",
-      "reply_required": "reply required",
-      "stalled_peer": "stalled peer",
-      "mention": "mention"
-    },
-    "reminderSummary": {
-      "mention": "{{actor}} mentioned you.",
-      "replyRequired": "{{actor}} is waiting for your reply.",
-      "stalledPeer": "{{actor}} has been idle for a while on {{taskId}}."
-    }
   }
 }

web/src/i18n/locales/en/webPet.json

@@ -1,25 +1,39 @@
 {
-  "panelLabel": "Web Pet panel",
-  "closePanel": "Close panel",
-  "noActionItems": "No pending items",
+  "panelAria": "Web Pet panel",
+  "closePanelAria": "Close panel",
+  "dismissReminderAria": "Dismiss reminder",
+  "bubbleAria": "Web Pet",
+  "bubbleAriaHint": "Web Pet. {{hint}}",
+  "teamFallback": "Team",
+  "systemAgent": "System",
+  "taskFallback": "this task",
+  "connection": {
+    "connected": "Connected",
+    "connecting": "Connecting…",
+    "disconnected": "Disconnected"
+  },
   "countWorking": "{{count}} working",
   "countBusy": "{{count}} busy",
   "countNeedsYou": "{{count}} needs you",
-  "dismissReminder": "Dismiss reminder",
-  "reminderKind_waiting_user": "waiting user",
-  "reminderKind_reply_required": "reply required",
-  "reminderKind_stalled_peer": "stalled peer",
-  "reminderKind_mention": "mention",
-  "reminderAction_complete": "Done",
-  "reminderAction_view": "View",
-  "reminderAction_reply": "Reply",
-  "connectionConnected": "Connected",
-  "connectionConnecting": "Connecting...",
-  "connectionDisconnected": "Disconnected",
+  "noActionItems": "No action items right now.",
+  "kind": {
+    "waiting_user": "waiting user",
+    "reply_required": "reply required",
+    "stalled_peer": "stalled peer",
+    "mention": "mention"
+  },
+  "action": {
+    "complete": "Done",
+    "view": "View",
+    "reply": "Reply"
+  },
   "taskProgress": "{{done}}/{{total}} done",
   "taskActive": "{{count}} active",
-  "actionView": "View",
-  "actionReply": "Reply",
   "hintTaskProgress": "{{done}}/{{total}} tasks done",
-  "hintTaskWithAction": "{{done}}/{{total}} done, {{count}} need you"
+  "hintTaskWithAction": "{{done}}/{{total}} done, {{count}} need you",
+  "reminderSummary": {
+    "mention": "{{actor}} mentioned you.",
+    "replyRequired": "{{actor}} is waiting for your reply.",
+    "stalledPeer": "{{actor}} has been idle for a while on {{taskId}}."
+  }
 }