Skip to content

DB Access not Async #37

@IAPark

Description

@IAPark

This is actually an issue I have fixed, but it's part of a much larger overhaul, now stalled until I have more time, meant to fix architectural issues and add unit testing. Regardless it's something that probably should be resolved before the next map. To be honest I thought it had been fixed so I was a bit surprised to find the code still blocking.

My code hasn't been tested and as I mentioned there are a number of other massive refactors, but this should give an idea of what's needed in general.

https://github.com/IAPark/Bastion/blob/Bastion-Storage-Refactor/Bastion/src/isaac/bastion/BastionBlock.java#L143-L160

Here's how it's currently handled

https://github.com/Civcraft/Bastion/blob/master/Bastion/src/isaac/bastion/BastionBlock.java#L169-L187

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions