You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As we discussed in person, PR #7 is merged leaving a few desiderata for the future. Here is a list of open points:
dangling return statements in Featurizer.add_... methods should be removed
some Featurizer.add_... docstrings state falsely that the method returns the data
Featurizer should not have the reference ensemble as a field. Instead, it should have a state that can be read from an h5 file, which can contain reference structures, TICA coordinates, etc.
instead of excluding bins from the divergence computation, I would instead set a minimum base density as done by Aleks in the force optimization paper.
Inclusion of TICA MSE and Jeffrey's divergence would be nice to complement JS and KL
TICA construction with deeptime should be moved to a different function (maybe we could establish a Featurizer.register_... framework alongside .add_... and .get_...; with new methods Featurizer.register_TICA(lagtime) as well as Featurizer.register_reference_structure(frame, structure_name) etc.
As we discussed in person, PR #7 is merged leaving a few desiderata for the future. Here is a list of open points:
returnstatements inFeaturizer.add_...methods should be removedFeaturizer.add_...docstrings state falsely that the method returns the dataFeaturizershould not have the reference ensemble as a field. Instead, it should have a state that can be read from an h5 file, which can contain reference structures, TICA coordinates, etc.Featurizer.register_...framework alongside.add_...and.get_...; with new methodsFeaturizer.register_TICA(lagtime)as well asFeaturizer.register_reference_structure(frame, structure_name)etc.