From 877c2b7eedb0bd09b8dcd1c8f223f02ee3e46476 Mon Sep 17 00:00:00 2001 From: Dani Sandoval Date: Tue, 21 Jul 2026 15:19:36 -0600 Subject: [PATCH 1/2] ci(publish): run publish workflows on Node 24 and drop the npm@latest upgrade MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `npm install -g npm@latest` now pulls npm 12, which dropped support for Node 23 (EBADENGINE: requires ^22.22.2 || ^24.15.0 || >=26.0.0). Both publish workflows pinned node-version 23.x, so the "Upgrade npm for OIDC support" step failed and no publish ever ran. Bump both workflows to Node 24.x, which bundles npm 11.16+ — new enough for OIDC trusted publishing on its own — and remove the now-unnecessary global npm upgrade step. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/publish.yml | 10 +++------- .github/workflows/release-publisher.yml | 10 +++------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 3ab91028d..85c6a8f05 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -78,14 +78,10 @@ jobs: npm pkg set version=$NEW_VERSION --no-git-tag-version - uses: actions/setup-node@v6 with: - node-version: '23.x' - # registry-url is required for OIDC trusted publishing. Avoid `npm install -g npm@latest` - # on hosted runners — it can leave npm broken (e.g. MODULE_NOT_FOUND / promise-retry). + # Node 24.x bundles npm >= 11.5.1, which supports OIDC trusted publishing, + # so no global npm upgrade is needed. registry-url is required for OIDC. + node-version: '24.x' registry-url: 'https://registry.npmjs.org' - - name: Upgrade npm for OIDC support - run: | - npm install -g npm@latest - echo "npm version: $(npm --version)" - name: Enable Corepack run: corepack enable - name: Install dependencies diff --git a/.github/workflows/release-publisher.yml b/.github/workflows/release-publisher.yml index 38bf15752..029fb4154 100644 --- a/.github/workflows/release-publisher.yml +++ b/.github/workflows/release-publisher.yml @@ -102,15 +102,11 @@ jobs: if: steps.verify-merge.outputs.is_release == 'true' uses: actions/setup-node@v6 with: - node-version: '23.x' + # Node 24.x bundles npm >= 11.5.1, which supports OIDC trusted publishing, + # so no global npm upgrade is needed. registry-url is required for OIDC. + node-version: '24.x' registry-url: 'https://registry.npmjs.org' - - name: Upgrade npm for OIDC support - if: steps.verify-merge.outputs.is_release == 'true' - run: | - npm install -g npm@latest - echo "npm version: $(npm --version)" - - name: Enable Corepack if: steps.verify-merge.outputs.is_release == 'true' run: corepack enable From 9cb54a702ec2bf75d0a055c0e4f4c7ffb7921653 Mon Sep 17 00:00:00 2001 From: Dani Sandoval Date: Tue, 21 Jul 2026 15:41:41 -0600 Subject: [PATCH 2/2] ci(publish): drop diff-relative wording from setup-node comment Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/publish.yml | 4 ++-- .github/workflows/release-publisher.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 85c6a8f05..c5376da2e 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -78,8 +78,8 @@ jobs: npm pkg set version=$NEW_VERSION --no-git-tag-version - uses: actions/setup-node@v6 with: - # Node 24.x bundles npm >= 11.5.1, which supports OIDC trusted publishing, - # so no global npm upgrade is needed. registry-url is required for OIDC. + # Node 24.x bundles npm >= 11.5.1, which supports OIDC trusted publishing. + # registry-url is required for OIDC. node-version: '24.x' registry-url: 'https://registry.npmjs.org' - name: Enable Corepack diff --git a/.github/workflows/release-publisher.yml b/.github/workflows/release-publisher.yml index 029fb4154..3821d685a 100644 --- a/.github/workflows/release-publisher.yml +++ b/.github/workflows/release-publisher.yml @@ -102,8 +102,8 @@ jobs: if: steps.verify-merge.outputs.is_release == 'true' uses: actions/setup-node@v6 with: - # Node 24.x bundles npm >= 11.5.1, which supports OIDC trusted publishing, - # so no global npm upgrade is needed. registry-url is required for OIDC. + # Node 24.x bundles npm >= 11.5.1, which supports OIDC trusted publishing. + # registry-url is required for OIDC. node-version: '24.x' registry-url: 'https://registry.npmjs.org'