Fix: dm path variable 수정 #57

Author: 5jisoo

src/main/java/com/coastee/server/dmroom/controller/DMRoomController.java

@@ -7,7 +7,6 @@
 import com.coastee.server.dmroom.dto.DMRoomElements;
 import com.coastee.server.dmroom.facade.DMRoomFacade;
 import com.coastee.server.global.apipayload.ApiResponse;
-import com.coastee.server.user.facade.UserFacade;
 import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.web.PageableDefault;
@@ -20,31 +19,26 @@
 
 @RequiredArgsConstructor
 @RestController
-@RequestMapping("/api/v1/users/{userId}/dms")
+@RequestMapping("/api/v1/dms")
 public class DMRoomController {
-    private final UserFacade userFacade;
     private final DMRoomFacade dmRoomFacade;
 
     @GetMapping("")
     @UserOnly
     public ApiResponse<DMRoomElements> getRooms(
             @Auth final Accessor accessor,
-            @PathVariable("userId") final Long userId,
             @PageableDefault(DEFAULT_PAGING_SIZE) final Pageable pageable
     ) {
-        userFacade.validateAccess(accessor, userId);
         return ApiResponse.onSuccess(dmRoomFacade.getRooms(accessor, pageable));
     }
 
     @GetMapping("/{roomId}")
     @UserOnly
     public ApiResponse<DMElements> getChats(
             @Auth final Accessor accessor,
-            @PathVariable("userId") final Long userId,
             @PathVariable("roomId") final Long roomId,
             @PageableDefault(DEFAULT_PAGING_SIZE) final Pageable pageable
     ) {
-        userFacade.validateAccess(accessor, userId);
         return ApiResponse.onSuccess(dmRoomFacade.getChats(accessor, roomId, pageable));
     }
 }

src/test/java/com/coastee/server/dmroom/controller/DMRoomControllerTest.java

@@ -88,9 +88,6 @@ void getRooms() throws Exception {
                 .contentType(MediaType.APPLICATION_JSON_VALUE)
                 .filter(
                         document("find-all-dmroom",
-                                pathParameters(
-                                        parameterWithName("userId").description("유저 아이디")
-                                ),
                                 queryParameters(
                                         parameterWithName("page").description("페이지 번호 (default: 0)")
                                 ),
@@ -135,7 +132,7 @@ void getRooms() throws Exception {
                                         fieldWithPath("result.dmRoomList[].dm.dmRoomId").type(NUMBER).description("DM의 채팅방 아이디")
                                 )
                         ))
-                .when().get("/api/v1/users/{userId}/dms", 1)
+                .when().get("/api/v1/dms")
                 .then().log().all().statusCode(200);
     }
 
@@ -169,7 +166,6 @@ void getChats() throws Exception {
                 .filter(
                         document("find-all-dms",
                                 pathParameters(
-                                        parameterWithName("userId").description("유저 아이디"),
                                         parameterWithName("roomId").description("DM 채팅방 아이디")
                                 ),
                                 queryParameters(
@@ -205,7 +201,7 @@ void getChats() throws Exception {
                                         fieldWithPath("result.dmList[].dmRoomId").type(NUMBER).description("DM의 채팅방 아이디")
                                 )
                         ))
-                .when().get("/api/v1/users/{userId}/dms/{roomId}", currentUser.getId(), dmRoom.getId())
+                .when().get("/api/v1/dms/{roomId}", dmRoom.getId())
                 .then().log().all().statusCode(200);
     }
 }