diff --git a/index.html b/index.html index af638da..0cee741 100644 --- a/index.html +++ b/index.html @@ -1,4 +1,4 @@ - + diff --git a/index.js b/index.js index 4c2a94e..c393966 100644 --- a/index.js +++ b/index.js @@ -1,12 +1,12 @@ -const guessInput = document.getElementById('guess'); -const submitButton = document.getElementById('submit'); -const resetButton = document.getElementById('reset'); -const messages = document.getElementsByClassName('message'); -const tooHighMessage = document.getElementById('too-high'); -const tooLowMessage = document.getElementById('too-low'); -const maxGuessesMessage = document.getElementById('max-guesses'); -const numberOfGuessesMessage = document.getElementById('number-of-guesses'); -const correctMessage = document.getElementById('correct'); +const guessInput = document.getElementById("guess"); +const submitButton = document.getElementById("submit"); +const resetButton = document.getElementById("reset"); +const messages = document.getElementsByClassName("message"); +const tooHighMessage = document.getElementById("too-high"); +const tooLowMessage = document.getElementById("too-low"); +const maxGuessesMessage = document.getElementById("max-guesses"); +const numberOfGuessesMessage = document.getElementById("number-of-guesses"); +const correctMessage = document.getElementById("correct"); let targetNumber; let attempts = 0; @@ -25,15 +25,18 @@ function getRandomNumber(min, max) { function checkGuess() { // Get value from guess input element const guess = parseInt(guessInput.value, 10); + if (guess < 1 || guess > 99) { + return; + } attempts = attempts + 1; hideAllMessages(); if (guess === targetNumber) { - numberOfGuessesMessage.style.display = ''; + numberOfGuessesMessage.style.display = ""; numberOfGuessesMessage.innerHTML = `You made ${attempts} guesses`; - correctMessage.style.display = ''; + correctMessage.style.display = ""; submitButton.disabled = true; guessInput.disabled = true; @@ -41,50 +44,54 @@ function checkGuess() { if (guess !== targetNumber) { if (guess < targetNumber) { - tooLowMessage.style.display = ''; + tooLowMessage.style.display = ""; } else { - tooLowMessage.style.display = ''; + tooHighMessage.style.display = ""; //fixed tooLowMessage to tooHighMessage } const remainingAttempts = maxNumberOfAttempts - attempts; - numberOfGuessesMessage.style.display = ''; - numberOfGuessesMessage.innerHTML = `You guessed ${guess}.
${remainingAttempts} guesses remaining`; + let guessNum = remainingAttempts === 1 ? "guess" : "guesses"; + + numberOfGuessesMessage.style.display = ""; + numberOfGuessesMessage.innerHTML = `You guessed ${guess}.
${remainingAttempts} ${guessNum} remaining`; } - if (attempts ==== maxNumberOfAttempts) { + if (attempts === maxNumberOfAttempts) { + //fixed ==== to === submitButton.disabled = true; guessInput.disabled = true; } - guessInput.value = ''; + guessInput.value = ""; - resetButton.style.display = ''; + resetButton.style.display = ""; } function hideAllMessages() { - for (let elementIndex = 0; elementIndex <= messages.length; elementIndex++) { - messages[elementIndex].style.display = 'none'; + for (let elementIndex = 0; elementIndex < messages.length; elementIndex++) { + // fixed <= to < + messages[elementIndex].style.display = "none"; } } -funtion setup() { +function setup() { // Get random number targetNumber = getRandomNumber(1, 100); console.log(`target number: ${targetNumber}`); // Reset number of attempts - maxNumberOfAttempts = 0; + attempts = 0; //change wrong var: maxNumberOfAttempts to attempts // Enable the input and submit button - submitButton.disabeld = false; + submitButton.disabled = false; //fixed typo disabeld to disabled guessInput.disabled = false; hideAllMessages(); - resetButton.style.display = 'none'; -} + resetButton.style.display = "none"; +} // fixed funtion to function -submitButton.addEventListener('click', checkGuess); -resetButton.addEventListener('click', setup); +submitButton.addEventListener("click", checkGuess); +resetButton.addEventListener("click", setup); setup();