The hand-rolled pLimit helper in analyzePackageVersions catches task errors implicitly — if a promise rejects before being assigned to results[i], the slot stays undefined and the error disappears. The consumer checks if (!ageInfoResult) continue so it doesn't crash, but we lose visibility into what actually failed.
Right now every task produces a resolved promise (even the failure case returns null), so this isn't biting us in practice. But if anyone adds a task that can genuinely reject, the error would be swallowed with no logging.
The fix would be to either:
- Wrap each task call in a try/catch that logs the error before returning null
- Or use
Promise.allSettled and check for rejected promises in the results
The hand-rolled
pLimithelper inanalyzePackageVersionscatches task errors implicitly — if a promise rejects before being assigned toresults[i], the slot staysundefinedand the error disappears. The consumer checksif (!ageInfoResult) continueso it doesn't crash, but we lose visibility into what actually failed.Right now every task produces a resolved promise (even the failure case returns
null), so this isn't biting us in practice. But if anyone adds a task that can genuinely reject, the error would be swallowed with no logging.The fix would be to either:
Promise.allSettledand check for rejected promises in the results