fix: correctly handle issues relation array in linkPrToClaim (#123)

src/inngest/functions/process-pr-event.test.ts

@@ -270,3 +270,94 @@ describe('processPrEvent - awardRecommendedMerge XP capping', () => {
     );
   });
 });
+
+describe('processPrEvent - linkPrToClaim issues relation array', () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  const setupMock = (issuesArray: unknown) => {
+    const recommendationsMock = sb({
+      is: vi.fn().mockResolvedValue({
+        data: [
+          {
+            id: 1,
+            issue_id: 101,
+            issues: issuesArray,
+          },
+        ],
+      }),
+      update: vi.fn().mockResolvedValue({ error: null }),
+    });
+
+    const profilesMock = sb({
+      maybeSingle: vi.fn().mockResolvedValue({ data: { id: 'contributor-id' } }),
+    });
+
+    const pullRequestsMock = sb({
+      upsert: vi.fn().mockResolvedValue({ error: null }),
+    });
+
+    const installationRepositoriesMock = sb({
+      maybeSingle: vi.fn().mockResolvedValue({ data: { repo_full_name: 'owner/repo' } }),
+    });
+
+    wire({
+      recommendations: recommendationsMock,
+      profiles: profilesMock,
+      pull_requests: pullRequestsMock,
+      installation_repositories: installationRepositoriesMock,
+    });
+
+    return { recommendationsMock };
+  };
+
+  const evOpened = () => ({
+    data: {
+      payload: {
+        action: 'opened',
+        pull_request: {
+          id: 1234,
+          number: 1,
+          html_url: 'https://github.com/owner/repo/pull/1',
+          title: 'Fix issue',
+          body: 'Closes #123',
+          state: 'open',
+          draft: false,
+          merged: false,
+          merged_at: null,
+          closed_at: null,
+          created_at: '2026-01-01T00:00:00Z',
+          updated_at: '2026-01-01T00:00:00Z',
+          user: { login: 'contributor' },
+          base: { repo: { full_name: 'owner/repo' } },
+        },
+      },
+    },
+  });
+
+  it('handles issues relation returned as an array', async () => {
+    const { recommendationsMock } = setupMock([
+      { repo_full_name: 'owner/repo', github_issue_number: 123 },
+    ]);
+
+    await prRun({ event: evOpened(), step });
+
+    expect(recommendationsMock.update).toHaveBeenCalledWith(
+      expect.objectContaining({ linked_pr_url: 'https://github.com/owner/repo/pull/1' }),
+    );
+  });
+
+  it('handles issues relation returned as a single object', async () => {
+    const { recommendationsMock } = setupMock({
+      repo_full_name: 'owner/repo',
+      github_issue_number: 123,
+    });
+
+    await prRun({ event: evOpened(), step });
+
+    expect(recommendationsMock.update).toHaveBeenCalledWith(
+      expect.objectContaining({ linked_pr_url: 'https://github.com/owner/repo/pull/1' }),
+    );
+  });
+});

src/inngest/functions/process-pr-event.ts

@@ -4,6 +4,7 @@
 import { XP_SOURCE, xpForMerge, refIds, XP_REWARDS } from '@/lib/xp/sources';
 import { cacheDelByPrefix } from '@/lib/cache';
 import { buildPrRow, type IngestiblePr } from '@/lib/maintainer/pr-ingest';
+import { unwrapJoin } from '@/lib/supabase/inner-join';
 
 /**
  * Webhook handler for GitHub `pull_request` events.
@@ -170,13 +171,13 @@
     .is('linked_pr_url', null);
 
   for (const claim of claims ?? []) {
-    const raw = (claim as unknown as { issues: unknown }).issues;
-    const issue = Array.isArray(raw)
-      ? (raw[0] as { repo_full_name?: string; github_issue_number?: number } | undefined)
-      : (raw as { repo_full_name?: string; github_issue_number?: number } | undefined);
+    const issue = unwrapJoin<{ repo_full_name?: string; github_issue_number?: number }>(
+      (claim as unknown as { issues: unknown }).issues,
+    );
+
     if (!issue?.repo_full_name || typeof issue.github_issue_number !== 'number') continue;
     if (issue.repo_full_name === repo && issueRefs.includes(issue.github_issue_number)) {
       await sb.from('recommendations').update({ linked_pr_url: prUrl }).eq('id', claim.id);
       return { linked: true, recId: claim.id };
     }
   }
@@ -317,10 +318,9 @@
   for (const claim of claims ?? []) {
     // Supabase types the joined `issues` field as an array even for a
     // single-row !inner join. Normalise.
-    const raw = (claim as unknown as { issues: unknown }).issues;
-    const issue = Array.isArray(raw)
-      ? (raw[0] as { repo_full_name?: string; github_issue_number?: number } | undefined)
-      : (raw as { repo_full_name?: string; github_issue_number?: number } | undefined);
+    const issue = unwrapJoin<{ repo_full_name?: string; github_issue_number?: number }>(
+      (claim as unknown as { issues: unknown }).issues,
+    );
     if (!issue?.repo_full_name || typeof issue.github_issue_number !== 'number') continue;
     if (issue.repo_full_name === repo && issueRefs.includes(issue.github_issue_number)) {
       return (claim as { id: number }).id;

src/inngest/functions/recommendations-build.ts

@@ -1,6 +1,7 @@
 import { inngest } from '../client';
 import { getServiceSupabase } from '@/lib/supabase/service';
 import { filterAndRank, type ScoredIssue, type SkipCounts } from '@/lib/pipeline/recommend';
+import { unwrapJoin } from '@/lib/supabase/inner-join';
 import { SKIP_HISTORY_WINDOW_DAYS } from '@/lib/pipeline/constants';
 
 /**
@@ -75,10 +76,12 @@ export const recommendationsBuild = inngest.createFunction(
       const skipHistoryMap: Record<string, SkipCounts> = {};
       for (const row of skipsData ?? []) {
         const userId = row.user_id;
-        const issue = row.issues as unknown as {
+        const issue = unwrapJoin<{
           repo_full_name: string;
           repo_language: string | null;
-        };
+        }>((row as unknown as { issues: unknown }).issues);
+
+        if (!issue?.repo_full_name) continue;
 
         if (!skipHistoryMap[userId]) {
           skipHistoryMap[userId] = { byRepo: {}, byLanguage: {} };

src/lib/supabase/inner-join.ts

@@ -0,0 +1,3 @@
+export function unwrapJoin<T>(raw: unknown): T | undefined {
+  return Array.isArray(raw) ? (raw[0] as T) : (raw as T);
+}