fix: make installation repository events idempotent#264
Merged
jakharmonika364 merged 1 commit intoJun 6, 2026
Merged
Conversation
Contributor
|
@AbhishekMauryaGEEK is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jakharmonika364
approved these changes
Jun 6, 2026
jakharmonika364
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Excellent improvements to security, concurrency guards, and webhook replay idempotency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
installation_repositories.addedwebhook processing idempotent by replacinginsert()withupsert().Related Issue
Closes #262
Type of Change
What Changed?
insert()withupsert()when handlingrepositories_addedevents.(installation_id, repo_full_name).repositories_addedwebhook processing.Why?
GitHub may redeliver webhook events. The
installation_repositoriestable uses a composite primary key:(installation_id, repo_full_name)Using
insert()could cause duplicate-key failures if the same webhook is replayed or redelivered.Switching to
upsert()makes the operation idempotent and aligns this code path with the existing installation creation flow, which already usesupsert()for repository synchronization.Validation
npm run typecheck✅npm test✅Checklist