fix: enforce rate limits in maintainer actions#266
Merged
jakharmonika364 merged 1 commit intoJun 6, 2026
Merged
Conversation
Contributor
|
@AbhishekMauryaGEEK is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jakharmonika364
approved these changes
Jun 6, 2026
jakharmonika364
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Correctly enforces the rate-limiting result on the maintainer actions and adds solid unit test coverage for it. All tests and checks pass cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces rate limits in maintainer actions that previously called
rateLimit()but ignored the result.Related Issue
Closes #265
Type of Change
What Changed?
The following maintainer actions were calling
rateLimit()but did not checklimited.ok, allowing requests to continue even after the configured limit was exceeded:getRepoHealthOverview()getStaleIssues()getTopContributors()getFlaggedAccounts()Updated each function to:
rateLimit()resulterr('rate_limited', 'slow down', true)when the limit is exceededAdded regression tests covering all four actions to ensure rate limits are enforced consistently.
Why?
Most maintainer actions correctly enforce rate limits by checking
limited.ok.These four functions were inconsistent and effectively bypassed rate limiting because the result of
rateLimit()was discarded.This change makes rate-limit enforcement consistent across maintainer actions and prevents unnecessary database work after limits have been exceeded.
Validation
npx vitest run src/app/actions/maintainer.test.ts✅npm run typecheck✅npm test✅Checklist