Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/app/actions/maintainer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ import {
getCommunityLinks,
upsertCommunityLink,
deleteCommunityLink,
getRepoHealthOverview,
getStaleIssues,
getTopContributors,
getFlaggedAccounts,
} from './maintainer';
import * as detect from '@/lib/maintainer/detect';
import * as rateLimitLib from '@/lib/rate-limit';
Expand Down Expand Up @@ -286,4 +290,39 @@ describe('maintainer actions', () => {
if (!res.ok) expect(res.error.code).toBe('not_found');
});
});
it('getRepoHealthOverview returns rate_limited when rate limit exceeded', async () => {
vi.mocked(rateLimitLib.rateLimit).mockResolvedValue({ ok: false } as never);

const res = await getRepoHealthOverview();

expect(res.ok).toBe(false);
if (!res.ok) expect(res.error.code).toBe('rate_limited');
});

it('getStaleIssues returns rate_limited when rate limit exceeded', async () => {
vi.mocked(rateLimitLib.rateLimit).mockResolvedValue({ ok: false } as never);

const res = await getStaleIssues();

expect(res.ok).toBe(false);
if (!res.ok) expect(res.error.code).toBe('rate_limited');
});

it('getTopContributors returns rate_limited when rate limit exceeded', async () => {
vi.mocked(rateLimitLib.rateLimit).mockResolvedValue({ ok: false } as never);

const res = await getTopContributors();

expect(res.ok).toBe(false);
if (!res.ok) expect(res.error.code).toBe('rate_limited');
});

it('getFlaggedAccounts returns rate_limited when rate limit exceeded', async () => {
vi.mocked(rateLimitLib.rateLimit).mockResolvedValue({ ok: false } as never);

const res = await getFlaggedAccounts();

expect(res.ok).toBe(false);
if (!res.ok) expect(res.error.code).toBe('rate_limited');
});
});
24 changes: 20 additions & 4 deletions src/app/actions/maintainer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -633,13 +633,17 @@ export async function getRepoHealthOverview(): Promise<Result<RepoHealthRow[]>>
return err('not_authenticated', 'sign in first');
}

await rateLimit({
const limited = await rateLimit({
namespace: 'maintainer',
key: user.id,
limit: 30,
windowSec: 60,
});

if (!limited.ok) {
return err('rate_limited', 'slow down', true);
}

if (!(await isUserMaintainer(user.id))) {
return err('not_authorised', 'not a maintainer');
}
Expand Down Expand Up @@ -722,13 +726,17 @@ export async function getStaleIssues(): Promise<Result<StaleIssueRow[]>> {
return err('not_authenticated', 'sign in first');
}

await rateLimit({
const limited = await rateLimit({
namespace: 'maintainer',
key: user.id,
limit: 30,
windowSec: 60,
});

if (!limited.ok) {
return err('rate_limited', 'slow down', true);
}

if (!(await isUserMaintainer(user.id))) {
return err('not_authorised', 'not a maintainer');
}
Expand Down Expand Up @@ -804,13 +812,17 @@ export async function getTopContributors(): Promise<Result<ContributorRow[]>> {
return err('not_authenticated', 'sign in first');
}

await rateLimit({
const limited = await rateLimit({
namespace: 'maintainer',
key: user.id,
limit: 30,
windowSec: 60,
});

if (!limited.ok) {
return err('rate_limited', 'slow down', true);
}

if (!(await isUserMaintainer(user.id))) {
return err('not_authorised', 'not a maintainer');
}
Expand Down Expand Up @@ -1096,13 +1108,17 @@ export async function getFlaggedAccounts(): Promise<Result<FlaggedAccountRow[]>>
return err('not_authenticated', 'sign in first');
}

await rateLimit({
const limited = await rateLimit({
namespace: 'maintainer',
key: user.id,
limit: 30,
windowSec: 60,
});

if (!limited.ok) {
return err('rate_limited', 'slow down', true);
}

if (!(await isUserMaintainer(user.id))) {
return err('not_authorised', 'not a maintainer');
}
Expand Down
Loading