Mod rewriter does not run for local mods

[viktor-ferenczi]

This is bad for mod developers.

Chat

[viktor-ferenczi]

Compilation pipeline findings

MyScriptManager.LoadData ([Decompiled/Sandbox.Game/Sandbox/Game/World/MyScriptManager.cs:83-152](Decompiled/Sandbox.Game/Sandbox/Game/World/MyScriptManager.cs)) iterates MySession.Static.Mods. Local mods (no workshop data) and workshop mods take the same code path: LoadScripts(mod.GetPath(), myModContext) → Compile(...).

MyScriptManager.Compile (line 224) calls MyVRage.Platform.Scripting.CompileAsync(MyApiTarget.Mod, ...) for every mod regardless of source.

MyScriptCompiler.Compile (line 89) calls CreateCompilation(assemblyName, scripts, enableDebugInformation) at line 117 — this is the method patched by CompilerHook.cs.

ModItem.GetPath ([MyObjectBuilder_Checkpoint.cs:528](Decompiled/VRage.Game/VRage/Game/MyObjectBuilder_Checkpoint.cs)) returns m_workshopItem.Folder for workshop mods, else Path.Combine(MyFileSystem.ModsPath, Name) for local mods. No differentiated compile path exists in the game code.

Conclusion

There is no game-level branch that would skip CreateCompilation for local mods. They should hit the same Harmony hook. If the rewriter actually isn't running for local mods, the cause is likely:

• A difference in how the analysis compilation's diagnostics resolve (local mods may produce warnings without errors, so !analysisCompilation.GetDiagnostics().Any(d => d.Severity == DiagnosticSeverity.Error) returns true → the rewriter early-exits and returns initialTrees), OR
• The mod genuinely compiles on the old TFM with no errors but fails elsewhere, OR
• Local mods are exercising a different path (e.g., the hook's Prefix skip guard) that you haven't instrumented yet.

Worth checking

• Add a log at the top of CreateCompilation_Prefix.Prefix to confirm whether it fires at all for local mods.