jvm.json questions

[rondlh]

1. Why is this argument split in 2 lines?

"--add-exports",
"javafx.graphics/com.sun.javafx.util=ALL-UNNAMED",

Couldn't it just be:
"--add-exports javafx.graphics/com.sun.javafx.util=ALL-UNNAMED",

2. Do we actually need all these arguments? If I run the Jar without them I don't see any issues.

{
	"javafx.graphics/com.sun.javafx.css=ALL-UNNAMED",
	"--add-exports",
	"javafx.controls/com.sun.javafx.scene.control.behavior=ALL-UNNAMED",
	"--add-exports",
	"javafx.controls/com.sun.javafx.scene.control=ALL-UNNAMED",
	"--add-exports",
	"javafx.base/com.sun.javafx.event=ALL-UNNAMED",
	"--add-exports",
	"javafx.controls/com.sun.javafx.scene.control.skin.resources=ALL-UNNAMED",
	"--add-exports",
	"javafx.graphics/com.sun.javafx.util=ALL-UNNAMED",
	"--add-exports",
	"javafx.graphics/com.sun.javafx.scene.input=ALL-UNNAMED",
	"--add-opens",
	"javafx.graphics/javafx.scene=ALL-UNNAMED"]
},

[madhephaestus]

when passing arguments to the system call method spaces are disallowed and each argument must be specified independently. This is a system call injection prevention strategy that is enforced at the system call method level.

If some of the arguments can be removed without afecting functionality, then i am cool with that. each was added because of some JVM level feature not working and the argument being needed at some point, but TBH i just have been accumulating those arguments to make the java 17 JVM work the same as the java8 JVM.

[rondlh]

when passing arguments to the system call method spaces are disallowed and each argument must be specified independently. This is a system call injection prevention strategy that is enforced at the system call method level.

If some of the arguments can be removed without afecting functionality, then i am cool with that. each was added because of some JVM level feature not working and the argument being needed at some point, but TBH i just have been accumulating those arguments to make the java 17 JVM work the same as the java8 JVM.

​About item 1. It seems the jvm arguments are just reconstructed to become a command line arguments for the java executable (getCommandString function). The command line will have spaces, they can come directly from the json file or they are inserted between the strings in the string list. I don't see the difference.
Either way...

About 2. If the application would need these arguments, and it doesn't get them, then the application would crash. I believe the task that the arguments are trying to do is done by the shadowJar already.
For Windows I can confirm that they are not needed. I don't know about other platforms, but I expect the same as they all use the same Jar file. A smaller jvm.json file would be better.

[madhephaestus]

yeah, if this is the case then the add exports and add opens can be removed from the jvm.json I know that setting the ram level and forcing the GPU usage is actually needed though.

[rondlh]

I left them in for now to not make too many changes at once.
I can confirm that the --add-opens and --add-exports are not needed for Windows.
If you can confirm that they are not needed for Linux/Mac then I can delete them.
Note, you can just manually launch the jar with "java -jar CaDoodle-Application.jar" for testing.