From 73c439c8625e08ffc111fb7f04264c00dd77bdff Mon Sep 17 00:00:00 2001 From: Imko Marijnissen Date: Thu, 17 Sep 2026 12:09:11 +0200 Subject: [PATCH 1/2] chore: Avoid unnecessarily querying twice --- .../conflict-resolvers/src/resolvers/working_nogood.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs b/pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs index c7cbd783f..e057aea7a 100644 --- a/pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs +++ b/pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs @@ -91,10 +91,13 @@ impl WorkingNogood { predicate_id_generator: &mut PredicateIdGenerator, mode: AnalysisMode, ) { + // Its corresponding predicate id, computed once and reused below. + let predicate_id = predicate_id_generator.get_id(predicate); + if self.is_redundant( predicate, context, - predicate_id_generator.get_id(predicate), + predicate_id, predicate_id_generator, mode, ) { @@ -105,8 +108,6 @@ impl WorkingNogood { // We first retrieve the value that the predicate will get in the heap let heap_value = get_heap_value(predicate, context); - // And its corresponding predicate id - let predicate_id = predicate_id_generator.get_id(predicate); // Next, we restore the key in the heap self.to_process_heap.restore_key(predicate_id); From 9e70a4aa1f89afb5cd1ab7bb66a630f77850df73 Mon Sep 17 00:00:00 2001 From: Imko Marijnissen Date: Thu, 17 Sep 2026 13:24:50 +0200 Subject: [PATCH 2/2] chore: remove comment --- .../conflict-resolvers/src/resolvers/working_nogood.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs b/pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs index e057aea7a..c35484bb1 100644 --- a/pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs +++ b/pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs @@ -91,7 +91,6 @@ impl WorkingNogood { predicate_id_generator: &mut PredicateIdGenerator, mode: AnalysisMode, ) { - // Its corresponding predicate id, computed once and reused below. let predicate_id = predicate_id_generator.get_id(predicate); if self.is_redundant(