From 0d3e84b038f3627b81b42e97797be776ade28a97 Mon Sep 17 00:00:00 2001 From: Erik Marks <25517051+rekmarks@users.noreply.github.com> Date: Wed, 2 Sep 2026 09:23:02 -0700 Subject: [PATCH 1/2] chore(ci): delete dead preview workflow, relax coverage and Slack requirements Three unrelated CI cleanups: - Delete `publish-preview.yml`. It invokes `yarn prepare-preview-builds`, `yarn publish-previews`, and `scripts/generate-preview-build-message.ts`, none of which exist in this repo, and its `PUBLISH_PREVIEW_NPM_TOKEN` is not configured. The workflow cannot have run successfully. - Mark `SLACK_WEBHOOK_URL` optional in `publish-release.yml`. The `slack-webhook-url` input of `MetaMask/action-npm-publish` is itself optional, and every Slack step in that action is guarded on it being non-empty, so requiring it here was stricter than the contract it feeds. - Stop failing the coverage report when no baseline exists, and derive the GitHub Pages URL from the workflow context instead of hardcoding it. A missing baseline now drops trend indicators instead of failing the job. Co-Authored-By: Claude Opus 5 --- .github/workflows/coverage-report.yml | 17 ++++++-- .github/workflows/publish-preview.yml | 58 --------------------------- .github/workflows/publish-release.yml | 2 +- 3 files changed, 15 insertions(+), 62 deletions(-) delete mode 100644 .github/workflows/publish-preview.yml diff --git a/.github/workflows/coverage-report.yml b/.github/workflows/coverage-report.yml index 0d00c3adb..8df9dce71 100644 --- a/.github/workflows/coverage-report.yml +++ b/.github/workflows/coverage-report.yml @@ -20,15 +20,26 @@ jobs: path: coverage/ - name: Fetch baseline coverage from GitHub Pages + id: baseline + env: + REPOSITORY: ${{ github.repository }} + REPOSITORY_OWNER: ${{ github.repository_owner }} run: | + url="https://${REPOSITORY_OWNER}.github.io/${REPOSITORY#*/}/coverage/coverage-summary.json" + mkdir -p coverage-base - curl -fsSL https://metamask.github.io/ocap-kernel/coverage/coverage-summary.json \ - -o coverage-base/coverage-summary.json || { echo "No baseline coverage found"; exit 1; } + if curl -fsSL "$url" -o coverage-base/coverage-summary.json; then + echo "path=coverage-base/coverage-summary.json" >> "$GITHUB_OUTPUT" + else + echo "::warning::No baseline coverage found at $url; reporting without trends." + echo "path=" >> "$GITHUB_OUTPUT" + fi - name: Post coverage report uses: davelosert/vitest-coverage-report-action@5b6122e3a819a3be7b27fc961b7faafb3bf00e4d with: json-summary-path: coverage/coverage-summary.json json-final-path: coverage/coverage-final.json - json-summary-compare-path: coverage-base/coverage-summary.json + # An empty path disables trend comparison. + json-summary-compare-path: ${{ steps.baseline.outputs.path }} file-coverage-mode: changes diff --git a/.github/workflows/publish-preview.yml b/.github/workflows/publish-preview.yml deleted file mode 100644 index 518173387..000000000 --- a/.github/workflows/publish-preview.yml +++ /dev/null @@ -1,58 +0,0 @@ -name: Publish a preview build - -on: - issue_comment: - types: created - -jobs: - is-fork-pull-request: - name: Determine whether this issue comment was on a pull request from a fork - if: ${{ github.event.issue.pull_request && startsWith(github.event.comment.body, '@metamaskbot publish-preview') }} - runs-on: ubuntu-latest - outputs: - IS_FORK: ${{ steps.is-fork.outputs.IS_FORK }} - steps: - - uses: actions/checkout@v7 - - name: Determine whether this PR is from a fork - id: is-fork - run: echo "IS_FORK=$(gh pr view --json isCrossRepository --jq '.isCrossRepository' "${PR_NUMBER}" )" >> "$GITHUB_OUTPUT" - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - PR_NUMBER: ${{ github.event.issue.number }} - - publish-preview: - name: Publish build preview - needs: is-fork-pull-request - permissions: - pull-requests: write - # This ensures we don't publish on forks. We can't trust forks with this token. - if: ${{ needs.is-fork-pull-request.outputs.IS_FORK == 'false' }} - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v7 - - name: Check out pull request - run: gh pr checkout "${PR_NUMBER}" - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - PR_NUMBER: ${{ github.event.issue.number }} - - name: Checkout and setup environment - uses: MetaMask/action-checkout-and-setup@v3 - with: - is-high-risk-environment: true - - name: Get commit SHA - id: commit-sha - run: echo "COMMIT_SHA=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT" - - run: yarn prepare-preview-builds @metamask-previews ${{ steps.commit-sha.outputs.COMMIT_SHA }} - - run: yarn build - - name: Publish preview build - run: yarn publish-previews - env: - YARN_NPM_AUTH_TOKEN: ${{ secrets.PUBLISH_PREVIEW_NPM_TOKEN }} - - name: Generate preview build message - run: yarn ts-node scripts/generate-preview-build-message.ts - - name: Post build preview in comment - run: gh pr comment "${PR_NUMBER}" --body-file preview-build-message.txt - env: - COMMIT_SHA: ${{ steps.commit-sha.outputs.COMMIT_SHA }} - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - PR_NUMBER: ${{ github.event.issue.number }} diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 63c98b333..ca9af9783 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -6,7 +6,7 @@ on: NPM_TOKEN: required: true SLACK_WEBHOOK_URL: - required: true + required: false jobs: publish-release: From acc8f04fdb925a5e46f6d0ec7e926c4d328ecde7 Mon Sep 17 00:00:00 2001 From: Erik Marks <25517051+rekmarks@users.noreply.github.com> Date: Wed, 2 Sep 2026 09:38:25 -0700 Subject: [PATCH 2/2] chore: drop orphaned publish:preview scripts and their constraint The preview-build workflow was the only consumer of these scripts, so with it gone all 31 of them are unreachable, as is the constraint that required them of every published package. Removing the script from `template-package` also stops new packages from inheriting it. Co-Authored-By: Claude Opus 5 --- packages/agentmask/package.json | 1 - packages/create-package/package.json | 1 - packages/evm-wallet-experiment/package.json | 1 - packages/extension/package.json | 1 - packages/kernel-agents-repl/package.json | 1 - packages/kernel-agents/package.json | 1 - packages/kernel-browser-runtime/package.json | 1 - packages/kernel-cli/package.json | 1 - packages/kernel-errors/package.json | 1 - packages/kernel-language-model-service/package.json | 1 - packages/kernel-node-runtime/package.json | 1 - packages/kernel-platforms/package.json | 1 - packages/kernel-rpc-methods/package.json | 1 - packages/kernel-shims/package.json | 1 - packages/kernel-store/package.json | 1 - packages/kernel-test/package.json | 1 - packages/kernel-ui/package.json | 1 - packages/kernel-utils/package.json | 1 - packages/llm-bridge/package.json | 1 - packages/logger/package.json | 1 - packages/nodejs-test-workers/package.json | 1 - packages/ocap-jsonrpc-vat/package.json | 1 - packages/ocap-kernel/package.json | 1 - packages/omnium-gatherum/package.json | 1 - packages/remote-iterables/package.json | 1 - packages/sample-services/package.json | 1 - packages/service-discovery-types/package.json | 1 - packages/service-matcher/package.json | 1 - packages/sheaves/package.json | 1 - packages/streams/package.json | 1 - packages/template-package/package.json | 1 - yarn.config.cjs | 7 ------- 32 files changed, 38 deletions(-) diff --git a/packages/agentmask/package.json b/packages/agentmask/package.json index 19684ff03..abf0f7e84 100644 --- a/packages/agentmask/package.json +++ b/packages/agentmask/package.json @@ -38,7 +38,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/create-package/package.json b/packages/create-package/package.json index c9fe7ddc8..288938f82 100644 --- a/packages/create-package/package.json +++ b/packages/create-package/package.json @@ -37,7 +37,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/evm-wallet-experiment/package.json b/packages/evm-wallet-experiment/package.json index d504f3f01..7bf2c7347 100644 --- a/packages/evm-wallet-experiment/package.json +++ b/packages/evm-wallet-experiment/package.json @@ -38,7 +38,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/extension/package.json b/packages/extension/package.json index 226563fac..87470cc09 100644 --- a/packages/extension/package.json +++ b/packages/extension/package.json @@ -27,7 +27,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "postinstall": "../../scripts/playwright-install.sh", "start": "./scripts/start.sh", "test": "vitest run --config vitest.config.ts", diff --git a/packages/kernel-agents-repl/package.json b/packages/kernel-agents-repl/package.json index 6a52d9b86..ff684d3d6 100644 --- a/packages/kernel-agents-repl/package.json +++ b/packages/kernel-agents-repl/package.json @@ -38,7 +38,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-agents/package.json b/packages/kernel-agents/package.json index a6b65725b..acb733a3e 100644 --- a/packages/kernel-agents/package.json +++ b/packages/kernel-agents/package.json @@ -148,7 +148,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-browser-runtime/package.json b/packages/kernel-browser-runtime/package.json index 92cb9cf77..0e6464c5a 100644 --- a/packages/kernel-browser-runtime/package.json +++ b/packages/kernel-browser-runtime/package.json @@ -52,7 +52,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:build": "tsx ./test/build-tests.ts", "test:clean": "yarn test --no-cache --coverage.clean", diff --git a/packages/kernel-cli/package.json b/packages/kernel-cli/package.json index b5031b690..279f39ac8 100644 --- a/packages/kernel-cli/package.json +++ b/packages/kernel-cli/package.json @@ -34,7 +34,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-errors/package.json b/packages/kernel-errors/package.json index 24b74baf1..c8de71f7e 100644 --- a/packages/kernel-errors/package.json +++ b/packages/kernel-errors/package.json @@ -48,7 +48,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-language-model-service/package.json b/packages/kernel-language-model-service/package.json index efea3c81c..8a27529fe 100644 --- a/packages/kernel-language-model-service/package.json +++ b/packages/kernel-language-model-service/package.json @@ -78,7 +78,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:e2e": "vitest run --config vitest.config.e2e.ts", "test:clean": "yarn test --no-cache --coverage.clean", diff --git a/packages/kernel-node-runtime/package.json b/packages/kernel-node-runtime/package.json index 6540dff95..d26da22b4 100644 --- a/packages/kernel-node-runtime/package.json +++ b/packages/kernel-node-runtime/package.json @@ -58,7 +58,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:e2e": "vitest run --config vitest.config.e2e.ts", "test:e2e:ci": "./scripts/test-e2e-ci.sh", diff --git a/packages/kernel-platforms/package.json b/packages/kernel-platforms/package.json index 583c4800e..40b9bdcbd 100644 --- a/packages/kernel-platforms/package.json +++ b/packages/kernel-platforms/package.json @@ -58,7 +58,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-rpc-methods/package.json b/packages/kernel-rpc-methods/package.json index 5d471bd52..1254f3849 100644 --- a/packages/kernel-rpc-methods/package.json +++ b/packages/kernel-rpc-methods/package.json @@ -48,7 +48,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-shims/package.json b/packages/kernel-shims/package.json index 1cdbef69d..05def590a 100644 --- a/packages/kernel-shims/package.json +++ b/packages/kernel-shims/package.json @@ -41,7 +41,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-store/package.json b/packages/kernel-store/package.json index 638ab1fcd..0fe85b80a 100644 --- a/packages/kernel-store/package.json +++ b/packages/kernel-store/package.json @@ -69,7 +69,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-test/package.json b/packages/kernel-test/package.json index b0ef8e0dd..d1cf39704 100644 --- a/packages/kernel-test/package.json +++ b/packages/kernel-test/package.json @@ -37,7 +37,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-ui/package.json b/packages/kernel-ui/package.json index 54a6128fa..7ea6d92e5 100644 --- a/packages/kernel-ui/package.json +++ b/packages/kernel-ui/package.json @@ -51,7 +51,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/kernel-utils/package.json b/packages/kernel-utils/package.json index 9ea10f398..55a700dc8 100644 --- a/packages/kernel-utils/package.json +++ b/packages/kernel-utils/package.json @@ -118,7 +118,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/llm-bridge/package.json b/packages/llm-bridge/package.json index d6674c6fd..d0318eaa8 100644 --- a/packages/llm-bridge/package.json +++ b/packages/llm-bridge/package.json @@ -41,7 +41,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/logger/package.json b/packages/logger/package.json index 9ce3c2721..554343d9a 100644 --- a/packages/logger/package.json +++ b/packages/logger/package.json @@ -58,7 +58,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/nodejs-test-workers/package.json b/packages/nodejs-test-workers/package.json index 8c68b4420..530252a6c 100644 --- a/packages/nodejs-test-workers/package.json +++ b/packages/nodejs-test-workers/package.json @@ -38,7 +38,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/ocap-jsonrpc-vat/package.json b/packages/ocap-jsonrpc-vat/package.json index 68912a38d..fd5f69a33 100644 --- a/packages/ocap-jsonrpc-vat/package.json +++ b/packages/ocap-jsonrpc-vat/package.json @@ -39,7 +39,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/ocap-kernel/package.json b/packages/ocap-kernel/package.json index ad655d1ec..5448c444c 100644 --- a/packages/ocap-kernel/package.json +++ b/packages/ocap-kernel/package.json @@ -59,7 +59,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/omnium-gatherum/package.json b/packages/omnium-gatherum/package.json index 780a8aae5..155d95dac 100644 --- a/packages/omnium-gatherum/package.json +++ b/packages/omnium-gatherum/package.json @@ -28,7 +28,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "postinstall": "../../scripts/playwright-install.sh", "start": "./scripts/start.sh", "test": "vitest run --config vitest.config.ts", diff --git a/packages/remote-iterables/package.json b/packages/remote-iterables/package.json index ec54ab556..38b37771b 100644 --- a/packages/remote-iterables/package.json +++ b/packages/remote-iterables/package.json @@ -38,7 +38,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/sample-services/package.json b/packages/sample-services/package.json index 423fd32c3..47e8ff124 100644 --- a/packages/sample-services/package.json +++ b/packages/sample-services/package.json @@ -39,7 +39,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/service-discovery-types/package.json b/packages/service-discovery-types/package.json index ed516dd27..1d10b27db 100644 --- a/packages/service-discovery-types/package.json +++ b/packages/service-discovery-types/package.json @@ -43,7 +43,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/service-matcher/package.json b/packages/service-matcher/package.json index 46033f59c..2f3828dcb 100644 --- a/packages/service-matcher/package.json +++ b/packages/service-matcher/package.json @@ -39,7 +39,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/sheaves/package.json b/packages/sheaves/package.json index 72d2e24a9..b8b867321 100644 --- a/packages/sheaves/package.json +++ b/packages/sheaves/package.json @@ -48,7 +48,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/packages/streams/package.json b/packages/streams/package.json index 853b587f6..21063fc55 100644 --- a/packages/streams/package.json +++ b/packages/streams/package.json @@ -59,7 +59,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "postinstall": "../../scripts/playwright-install.sh", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", diff --git a/packages/template-package/package.json b/packages/template-package/package.json index ea9abbd0b..446335bc8 100644 --- a/packages/template-package/package.json +++ b/packages/template-package/package.json @@ -38,7 +38,6 @@ "lint:eslint": "eslint . --cache", "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies", "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore --log-level error", - "publish:preview": "yarn npm publish --tag preview", "test": "vitest run --config vitest.config.ts", "test:clean": "yarn test --no-cache --coverage.clean", "test:dev": "yarn test --mode development", diff --git a/yarn.config.cjs b/yarn.config.cjs index 36f4a2161..f093f49b8 100644 --- a/yarn.config.cjs +++ b/yarn.config.cjs @@ -176,13 +176,6 @@ module.exports = defineConfig({ // Published packages must not have side effects. expectWorkspaceField(workspace, 'sideEffects', false); - // All published packages must have the same "publish:preview" script. - expectWorkspaceField( - workspace, - 'scripts.publish:preview', - 'yarn npm publish --tag preview', - ); - // All non-root package must have valid "changelog:update" and // "changelog:validate" scripts. expectCorrectWorkspaceChangelogScripts(workspace);