Skip to content
This repository was archived by the owner on May 1, 2026. It is now read-only.
This repository was archived by the owner on May 1, 2026. It is now read-only.

Semantic improvements #46

@kangarang

Description

@kangarang

i think it's worth changing some names to increase readability

majority bloc - group of voters who voted the majority rule

(plcr)
function isPassed -> majorityBlocVotedFor

  • returns true if the applicant won a challenge

(tcr)
uint rewardPool -> majorityBlocRewardPct

  • integer percentage value; used to calculate the amount of reward tokens transferred to msg.sender once claimReward is called

(plcr)
function getTotalNumberOfTokensForWinningOption -> getTotalMajorityBlocNumTokens

  • returns either the votesFor or votesAgainst (whichever is greater)

(tcr)
uint totalTokens -> totalMajorityBlocNumTokens

  • value returned from voting.getTotalNumberOfTokensForWinningOption -- either the votesFor or votesAgainst (whichever is greater)

winning voter - single voter who voted in the majority rule

(plcr)
function getNumPassingTokens -> getWinningVoterNumTokens

  • returns the number of tokens a majority bloc voter voted in a poll

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions