Comment reload causes alert box in Firefox and Safari

[rgilman]

Back in Oct 15 (see PR #133), we added some JS to reload comments after submitting a new comment in docs. Here's the script:

	jQuery('#submit').click(function(){
		setTimeout(function(){
			document.location.reload();
		}, 250);
	});

It all worked great in Brave/Chrome but now I'm discovering that our script causes an alert to briefly appear in Firefox. In Safari, the alert appears and needs to be dismissed by the user.

@iangilman, how can we fix this?

[rgilman]

The alert in firefox contains the base url for the site. The alert in safari is blank except for an OK button.

[iangilman]

Funky. I don't know why this is happening.

I suppose one possibility is there's a beforeunload event handler somewhere else on the page. You could test that hypothesis by adding something like this before your reload:

window.onbeforeunload = function() {};

That should overwrite any existing handler for that event.

[rgilman]

I tried

	jQuery('#submit').click(function(){
		window.onbeforeunload = function() {};
		setTimeout(function(){
			document.location.reload();
		}, 250);
	});

and

	jQuery('#submit').click(function(){
		setTimeout(function(){
			window.onbeforeunload = function() {};
			document.location.reload();
		}, 250);
	});

Neither made a difference.

[rgilman]

I may have a fix. This seems to work in Brave/Firefox/Safari:

	jQuery('#submit').click(function(){
		jQuery(document).ajaxComplete(function(){
			document.location.reload();
		});
	});

[iangilman]

Cool! I thought we tried something like that before, but I guess not. That's definitely a better solution all around, because we are no longer guessing how long it takes to load.