From 5d5f88aff620c7cfbf8955de6d8cb50e141288b5 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Tue, 9 Jun 2026 21:18:10 +0000 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Bolt:=20Optimize=20array=20iteratio?= =?UTF-8?q?ns=20over=20Prisma=20relations?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replaced chained `.reduce()` and `.map()` calls with single `for...of` loops when iterating over potentially large in-memory data arrays like `usageRecords` and `thisWeekRollups` generated by Prisma. These optimizations reduce overhead time by iterating only once. --- .jules/bolt.md | 3 ++ .../dashboard/sessions/[sessionId]/route.ts | 32 ++++++++++++------- .../[orgSlug]/dashboard/sessions/route.ts | 18 +++++++---- packages/web/src/lib/server/weekly-report.ts | 20 ++++++------ 4 files changed, 45 insertions(+), 28 deletions(-) create mode 100644 .jules/bolt.md diff --git a/.jules/bolt.md b/.jules/bolt.md new file mode 100644 index 0000000..55426d2 --- /dev/null +++ b/.jules/bolt.md @@ -0,0 +1,3 @@ +## 2024-06-09 - Avoid Multiple Iteration Passes Over In-Memory Relations +**Learning:** Found several places where the application performs multiple chained array iteration passes (like `.reduce()`, `.map()`) over potentially large datasets from Prisma `include` blocks. This increases memory overhead and iteration time, introducing performance bottlenecks specific to how Prisma handles relations in memory. +**Action:** When processing datasets from Prisma `include` blocks (like `usageRecords` or `thisWeekRollups`), combine calculations into a single `for...of` loop instead of multiple `.reduce()` or `.map()` passes to minimize iteration overhead. diff --git a/packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/[sessionId]/route.ts b/packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/[sessionId]/route.ts index 35486b8..dfcf5ee 100644 --- a/packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/[sessionId]/route.ts +++ b/packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/[sessionId]/route.ts @@ -43,18 +43,26 @@ export async function GET( return forbiddenByRole(access.role, '본인 세션만 열람 가능') } - const totalInput = session.usageRecords.reduce((sum, r) => sum + r.inputTokens, 0) - const totalOutput = session.usageRecords.reduce((sum, r) => sum + r.outputTokens, 0) - const totalCost = session.usageRecords.reduce((sum, r) => sum + (r.estimatedCostUsd ?? 0), 0) - - const usageTimeline: SessionTimelineUsage[] = session.usageRecords.map((r) => ({ - timestamp: r.timestamp.toISOString(), - inputTokens: r.inputTokens, - outputTokens: r.outputTokens, - estimatedCostUsd: r.estimatedCostUsd ?? 0, - model: r.model, - isSubagent: r.isSubagent, - })) + let totalInput = 0 + let totalOutput = 0 + let totalCost = 0 + const usageTimeline: SessionTimelineUsage[] = [] + + // ⚡ Bolt: Single pass iteration over in-memory relation array avoids multiple reduce/map passes + for (const r of session.usageRecords) { + totalInput += r.inputTokens + totalOutput += r.outputTokens + totalCost += r.estimatedCostUsd ?? 0 + + usageTimeline.push({ + timestamp: r.timestamp.toISOString(), + inputTokens: r.inputTokens, + outputTokens: r.outputTokens, + estimatedCostUsd: r.estimatedCostUsd ?? 0, + model: r.model, + isSubagent: r.isSubagent, + }) + } // 각 UsageRecord를 "직전 ASSISTANT 턴"에 귀속시켜 메시지별 토큰/비용/모델 집계. // TOOL 메시지는 건너뛰고 가장 가까운 선행 ASSISTANT로 타고 올라감. diff --git a/packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/route.ts b/packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/route.ts index 25fbe70..7afec68 100644 --- a/packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/route.ts +++ b/packages/web/src/app/api/orgs/[orgSlug]/dashboard/sessions/route.ts @@ -33,14 +33,18 @@ const sessionInclude = { type SessionWithInclude = Prisma.ClaudeSessionGetPayload<{ include: typeof sessionInclude }> function getSessionTotals(session: SessionWithInclude) { - return { - inputTokens: session.usageRecords.reduce((sum, r) => sum + r.inputTokens, 0), - outputTokens: session.usageRecords.reduce((sum, r) => sum + r.outputTokens, 0), - estimatedCostUsd: session.usageRecords.reduce( - (sum, r) => sum + (r.estimatedCostUsd ?? 0), - 0, - ), + let inputTokens = 0 + let outputTokens = 0 + let estimatedCostUsd = 0 + + // ⚡ Bolt: Single pass iteration over in-memory relation array avoids multiple reduce overhead + for (const r of session.usageRecords) { + inputTokens += r.inputTokens + outputTokens += r.outputTokens + estimatedCostUsd += r.estimatedCostUsd ?? 0 } + + return { inputTokens, outputTokens, estimatedCostUsd } } function mapSessionItem(session: SessionWithInclude): SessionItem { diff --git a/packages/web/src/lib/server/weekly-report.ts b/packages/web/src/lib/server/weekly-report.ts index ace2f44..5523ad3 100644 --- a/packages/web/src/lib/server/weekly-report.ts +++ b/packages/web/src/lib/server/weekly-report.ts @@ -446,17 +446,19 @@ export async function getWeeklyReport( } // Insights — delegation - const totalAgentCalls = thisWeekRollups.reduce( - (sum, r) => sum + Object.values(r.agentCounts).reduce((a, b) => a + b, 0), - 0, - ) - const totalSkillCalls = thisWeekRollups.reduce( - (sum, r) => sum + Object.values(r.skillCounts).reduce((a, b) => a + b, 0), - 0, - ) + let totalAgentCalls = 0 + let totalSkillCalls = 0 const distinctSkillsThisWeek = new Set() + + // ⚡ Bolt: Single pass iteration over rollups avoids multiple reduce overhead for (const r of thisWeekRollups) { - for (const k of Object.keys(r.skillCounts)) distinctSkillsThisWeek.add(k) + for (const count of Object.values(r.agentCounts)) { + totalAgentCalls += count + } + for (const [skillName, count] of Object.entries(r.skillCounts)) { + totalSkillCalls += count + distinctSkillsThisWeek.add(skillName) + } } const insights: WeeklyInsights = {