I understand that you made it such that clicking anywhere on the right half of the toolbar opens the search dialog, but it feels very odd and inconsistent with the rest of the Android platform. By using a standard menu item with the Toolbar, the search toggle code becomes simpler, and has better UX (IMO) i.e. ripple icon on search icon press, no weird behaviour where not pressing the search icon can open the search view.
I'm able to work on this, but would like some assurance that this would be an accepted change.
I understand that you made it such that clicking anywhere on the right half of the toolbar opens the search dialog, but it feels very odd and inconsistent with the rest of the Android platform. By using a standard menu item with the Toolbar, the search toggle code becomes simpler, and has better UX (IMO) i.e. ripple icon on search icon press, no weird behaviour where not pressing the search icon can open the search view.
I'm able to work on this, but would like some assurance that this would be an accepted change.