Missing Node-name Metricbeat

[kh4rdur]

Describe the bug
After upgrading from 4.7.1.stableX to 4.7.2.stableX we noticed an error regarding "name" missing in source Metricbeat.yaml.
This same issue was fixed in version 4.7.2.stable3 for Filebeat.
Looking at the values.yaml in the chart regarding the metricbeat.yaml the node_name value is set for the deployment stage, but not for the daemonset.

Adding
- name: NODE_NAME valueFrom: fieldRef: fieldPath: spec.nodeName

after the Metricbeat_index env value; fixes this issue.
https://github.com/CybercentreCanada/assemblyline-helm-chart/blob/34d4e554b3e5c74e33c885d834316e842142e9f7/charts/assemblyline/values.yaml#L905

To Reproduce
Steps to reproduce the behavior:
Go to version 4.7.1.stablex and upgrade to 4.7.2.stablex with metricbeat enabled.

[cccs-rs]

Hmm... that's weird, based on their helm chart for Daemonsets, it should be always included (unless I'm reading the template wrong?):
https://github.com/elastic/helm-charts/blob/0e5514fcddf4ea91763d35c35a8e7dc2e487ffd6/metricbeat/templates/daemonset.yaml#L135

[kh4rdur]

Looks like it, but for some reason it does not get picked up.
And with every update we see it being removed again :D so def. something wrong, like it is getting overruled in some way.