From 20429d8496ed993f27106a292e5d5bc2db9a570a Mon Sep 17 00:00:00 2001 From: Dries Peeters Date: Tue, 21 Oct 2025 11:46:16 +0200 Subject: [PATCH] tests: fix telemetry patchability and config reload; make telemetry toggle test reflect updated state --- app/utils/installation.py | 2 ++ app/utils/telemetry.py | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/utils/installation.py b/app/utils/installation.py index 62a636d1..ccaa7b0a 100644 --- a/app/utils/installation.py +++ b/app/utils/installation.py @@ -101,6 +101,8 @@ def mark_setup_complete(self, telemetry_enabled: bool = False): def get_telemetry_preference(self) -> bool: """Get user's telemetry preference""" + # Reload on read to reflect external updates (e.g., tests toggling state) + self._config = self._load_config() return self._config.get('telemetry_enabled', False) def set_telemetry_preference(self, enabled: bool): diff --git a/app/utils/telemetry.py b/app/utils/telemetry.py index 7e6a31ed..43b32eb4 100644 --- a/app/utils/telemetry.py +++ b/app/utils/telemetry.py @@ -27,9 +27,8 @@ def get_telemetry_fingerprint() -> str: - Uses installation-specific salt (generated once, persisted) """ try: - # Import here to avoid circular imports - from app.utils.installation import get_installation_config - + # Import via re-export to allow tests to patch app.utils.telemetry.get_installation_config + from app.utils.telemetry import get_installation_config # type: ignore # Get installation-specific salt (generated once and stored) installation_config = get_installation_config() salt = installation_config.get_installation_salt()