Border artifacts

[nadavsinai]

Hello Mr Ruijters,
Thank you for your wonderful work and related info docs.
I am keen to use your shader's code in a project I am working on,
I am curious to know if you have any clue to give me how to get rid of the border artifacts that exist (doubling of the last row of pixels) when panning out of the original picture.
I thought of adding a line of black pixels to the texture using texSubImage and a dummy fragment shader that will output black (or any other background color). have you got any other idea?
BTW. I suggest adding a "scroll to bottom" notice in your examples pages so people don't miss the algorithm selector
Thanks
Nadav Sinai

[DannyRuijters]

Dear Sinai,

Since the prefilter creates a new texture anyway, you can add a black (or any other color) border pixel in this processing step.
It also depends on which behavior you want. Mirroring or repeating is also possible, but a bit more complicated to achieve.

Kind regards,
Danny

From: Nadav Sinai [mailto:notifications@github.com]
Sent: 2016 Apr 25 9:37
To: DannyRuijters/CubicInterpolationWebGL
Subject: [DannyRuijters/CubicInterpolationWebGL] Border artifacts (#1)

Hello Mr Ruijters,
Thank you for your wonderful work and related info docs.
I am keen to use your shader's code in a project I am working on,
I am curious to know if you have any clue to give me how to get rid of the border artifacts that exist (doubling of the last row of pixels) when panning out of the original picture.
I thought of adding a line of black pixels to the texture using texSubImage and a dummy fragment shader that will output black (or any other background color). have you got any other idea?
BTW. I suggest adding a "scroll to bottom" notice in your examples pages so people don't miss the algorithm selector
Thanks
Nadav Sinai

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/1

---

The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.

[nadavsinai]

Hi Danny,

Sorry for the delay,

Thanks for your prompt response.
Just to make sure we speak of the same thing, and with regards to the
second part of your response, the repeating of pixels is what happens
already even in your examples when you zoom out further than the image
dimensions.
However I understand from your replyt that adding the black border in the
pre-filtering step is the way forward for me, so you can close the issue,
Nadav

On Tue, Apr 26, 2016 at 10:40 AM DannyRuijters notifications@github.com
wrote:

Dear Sinai,

Since the prefilter creates a new texture anyway, you can add a black (or
any other color) border pixel in this processing step.
It also depends on which behavior you want. Mirroring or repeating is also
possible, but a bit more complicated to achieve.

Kind regards,
Danny

From: Nadav Sinai [mailto:notifications@github.com]
Sent: 2016 Apr 25 9:37
To: DannyRuijters/CubicInterpolationWebGL
Subject: [DannyRuijters/CubicInterpolationWebGL] Border artifacts (#1)

Hello Mr Ruijters,
Thank you for your wonderful work and related info docs.
I am keen to use your shader's code in a project I am working on,
I am curious to know if you have any clue to give me how to get rid of the
border artifacts that exist (doubling of the last row of pixels) when
panning out of the original picture.
I thought of adding a line of black pixels to the texture using
texSubImage and a dummy fragment shader that will output black (or any
other background color). have you got any other idea?
BTW. I suggest adding a "scroll to bottom" notice in your examples pages
so people don't miss the algorithm selector
Thanks
Nadav Sinai

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub<
https://github.com/DannyRuijters/CubicInterpolationWebGL/issues/1>

---

The information contained in this message may be confidential and legally
protected under applicable law. The message is intended solely for the
addressee(s). If you are not the intended recipient, you are hereby
notified that any use, forwarding, dissemination, or reproduction of this
message is strictly prohibited and may be unlawful. If you are not the
intended recipient, please contact the sender by return e-mail and destroy
all copies of the original message.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1 (comment)