Skip to content

Em-dash U+2014 in agentdb-mcp-server.ts L268 comment (inherited from #35 commit b8d1ff2) #41

@DarkCodePE

Description

@DarkCodePE

Inherited debt from [260526-kpoimj] (issue #35, commit b8d1ff2).

The SPARC-C completion review for #35 missed an em-dash (U+2014) in a new inline comment:

```
agentdb/src/mcp/agentdb-mcp-server.ts:268
// Resolve GNN learning backend for MCP path (M8 — same resolver as AgentDB core, per D8)
```

This violates agent-rules.md §6 "No signature AI tells. Avoid patterns that mark text as auto-generated: em-dashes ( and ), for which you should substitute -, :, or (...) whichever reads most naturally".

Why this slipped through #35: The SPARC-C reviewer agent for #35 ran the anti-corruption sweep against `ce-/agentmemory/am-/cognitive-engineering` patterns but did NOT include em-dash detection in the grep regex. Subsequent SPARC-C for #36 caught the same pattern in #36's new comments but L268 was already in FROZEN territory and could not be modified retroactively.

Fix: Replace with - on L268. One-character change. No tests affected.

Process improvement (worth a separate ADR if not already): the anti-corruption sweep in SPARC-C should always include [—–] em/en-dash detection on new diff lines.

Affected commit: b8d1ff2 in branch feat/260526-kpoimj-gnn-enablement (local, not yet pushed due to EMU fork blocker).

Recommended fix path: amend b8d1ff2 (requires explicit user authorization to rewrite local history) OR new commit on a separate branch when the branch is unstacked.

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-triageMaintainer needs to evaluate

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions