After SigimaX merge, datalab point to the wrong settings folder

[StefanoPierini-Codra]

Bug: user plugin directory resolves to .none instead of .DataLab_v1

Component: datalab.config / datalab.plugins
Affected version: 1.3.0 (develop, unreleased — last tag is v1.2.2)
Type: regression, introduced by the SigimaX extraction
Severity: medium — no data loss, but user plugins silently stop being discovered

Symptom

The default user plugin directory changed from ~/.config/.DataLab_v1/plugins to ~/.config/.none/plugins (on Windows: %USERPROFILE%\.DataLab_v1\plugins → %USERPROFILE%\.none\plugins).

Consequences:

• plugins previously installed by the user are no longer loaded;
• the path shown in Plugins > Configure plugins... points to the wrong directory, so newly installed plugins land in .none too;
• a stray ~/.config/.none/ directory is created on every startup.

Root cause

datalab/plugins.py resolves its default path at import time:

PLUGINS_DEFAULT_PATH = get_config_path("plugins")

if not osp.isdir(PLUGINS_DEFAULT_PATH):
    os.makedirs(PLUGINS_DEFAULT_PATH)

get_config_path() delegates to the guidata UserConfig backend held in sigimax.utils.conf.CONF. UserConfig.__init__ sets self.name = "none", and UserConfig.get_path() resolves — and creates — ~/.config/.{self.name}/…. The name only becomes correct once set_application() is called.

Before the SigimaX extraction the configuration was initialized while the config module itself was imported, so the name was always bound early enough. Now initialization is explicit and deferred (initialize() / ensure_initialized()), and it runs after datalab.app has imported datalab.gui.main → datalab.plugins. At that point CONF.name is still "none", so the plugin path is frozen to ~/.config/.none/plugins.

The failure is silent: no exception, no warning, just a wrong (and freshly created) directory.

[StefanoPierini-Codra]

Fix

Bind the application name as soon as the DataLab backend is installed, in datalab/config/persistence.py, immediately after the module rebinds sigimax.utils.conf.CONF:

if not isinstance(_confmod.CONF, DataLabUserConfig):
    _confmod.CONF = DataLabUserConfig({})

_confmod.CONF.set_application(get_config_app_name(), CONF_VERSION, load=False)

The directory name depends only on the application version, so it can be bound at import time. load=False guarantees no disk I/O: reading and writing the INI file remains the responsibility of initialize().

Why this exact location

Placing the call in datalab/config/appinfo.py looks more natural but does not work: persistence.py is imported later (via core.py) and replaces sigimax.utils.conf.CONF with a fresh DataLabUserConfig({}), which resets the name to "none". The binding must therefore live at the point where the backend identity is established.

Regression test

datalab/tests/backbone/config_persistence_unit_test.py::test_config_app_name_is_bound_at_import_time

The check must run in a subprocess: inside the pytest process the configuration has usually been initialized by the time the test executes, so an assertion on the already-imported PLUGINS_DEFAULT_PATH would pass even with the bug present. The subprocess imports datalab.plugins on a fresh interpreter, with HOME / USERPROFILE / XDG_CONFIG_HOME redirected to a temporary directory, and asserts that the plugin path lives under .{get_config_app_name()}.

Verified to fail (assert '.none' == '.DataLab_v1') when the fix is reverted.

[ThomasMalletCodra]

fixed and merged in : 5d29d50