Holograms are displayed on lower height if displayed for lower minecraft versions

[MorkaZ]

Just making sure

• I made sure, this bug is not already known or reported.
• I believe, that this bug is fixable.

Reproduction

I am using ViaVersion on my server to allow lower versions join to my server.
For versions at least below 1.20, holograms are on lower height than they should be. Just like on these 2 images (first one on 1.19.4, other one on 1.21.7)

Previously, before updating server, I was using HolographicDisplays which did not have that issue.

Solution

Add extra height to hologram (to y coordinate, probably +1) if player protocol is lower than version which causes this issue (still need to test up from which version it happens)

Server Version

1.21.5 (last purpur build)

Client Version

1.19.4 & 1.21.7

Plugin Version

2.9.4

Log

https://pastebin.com/bty4WYiW

[Andre601]

I don't think this is a DH issue, as DH doesn't do anything for cross-version support to my knowledge.
So whatever causes the shift in the text is not by DH, but by whatever plugin you use for older version support.

I personally recommend to not try and support older versions on your server. It can and will cause a lot of issues in various ways that isn't worth the little gain you get here.

[MorkaZ]

Source of issue is different version of client but it is very easy to fix it just by checking what protocol player has to adjust height.
The thing is, lots of servers are using ViaVersion to allow other versions than server version joining to the game. Problem is, lower versions had these holograms displayed on different height (a bit lower y) and thats the whole cause of the problem. My suggestion is - do the height fix like HolographicDisplays did in the past if client protocol will be lower than specific number.

[d0by1]

I could be wrong, but I don't believe HolographicDisplays ever had a "fix" for this. Feel free to link a source if you’re sure it did. Either way, this isn’t something that should be addressed in DecentHolograms. You're essentially asking us to fix an issue caused by ViaVersion. If anything needs to be fixed, it should be done in ViaVersion. Not in DecentHolograms, HolographicDisplays, or any other plugin, since none of these are responsible for allowing players to join with different versions.

[MorkaZ]

I mean, it was simply working in holographicDisplays so I guessed it had. On my 1.20.2 server, it is working perfectly on all older clients. Meanwhile it does not in DecentHolograms. I guess HolographicDisplays was displaying it differently for other versions.
See this then as feature requests which will be huge for ViaVersion servers (which are many).