Skip to content

Commit 6738e61

Browse files
committed
Change Slack message format
Slack message format improvements.
1 parent 26967e3 commit 6738e61

1 file changed

Lines changed: 18 additions & 7 deletions

File tree

modules/notifier/lambda/dd_notifier_lambda.py

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,10 @@ def process_config_event(message):
8383
slack_message = None
8484
rule_name = message.get("configRuleName", None)
8585
if rule_name:
86-
old_result = message["oldEvaluationResult"]["complianceType"]
86+
if message["oldEvaluationResult"] is not None:
87+
old_result = message["oldEvaluationResult"]["complianceType"]
88+
else:
89+
old_result = "Not Recorded"
8790
new_result = message["newEvaluationResult"]["complianceType"]
8891
if old_result != new_result:
8992
color = SEVERITY_COLOR_CONFIG[new_result]
@@ -102,6 +105,7 @@ def process_config_event(message):
102105

103106
"fallback": "{0}: AWS Config State Change for {1} in {2}: \n{3}".format(new_result.upper(), rule_name, account_id, message_text),
104107
"color": color,
108+
"title": "Config Rule State Change",
105109
"fields": [
106110
{
107111
"title": "Rule Name",
@@ -124,13 +128,18 @@ def process_config_event(message):
124128
"short": "true"
125129
},
126130
{
127-
"title": "Message",
131+
"title": "Details",
128132
"value": message["newEvaluationResult"]["annotation"]
129133
},
130134
{
131-
"title": "Status",
135+
"title": "New Status",
132136
"value": new_result.replace("_", " ").title(),
133137
"short": "true",
138+
},
139+
{
140+
"title": "Old Status",
141+
"value": old_result.replace("_", " ").title(),
142+
"short": "true",
134143
}
135144
],
136145
"ts": alarm_time
@@ -158,8 +167,9 @@ def process_alarm_event(message):
158167
"attachments": [
159168
{
160169

161-
"fallback": "{0}: CloudTrail Alert for {1} in {2}: \n{3}".format(severity.title(), alarm_name, account_id, message_text),
170+
"fallback": "{0}: CloudTrail Alarm for {1} in {2}: \n{3}".format(severity.title(), alarm_name, account_id, message_text),
162171
"color": color,
172+
"title": "New CloudTrail Alarm",
163173
"fields": [
164174
{
165175
"title": "Alarm Name",
@@ -176,7 +186,7 @@ def process_alarm_event(message):
176186
"value": message["AlarmDescription"]
177187
},
178188
{
179-
"title": "Message",
189+
"title": "Details",
180190
"value": message["NewStateReason"]
181191
},
182192
{
@@ -211,9 +221,10 @@ def process_remediation_event(event):
211221

212222
"fallback": "{0}: Automated Remediation Taken on {1} ({2}) in {3}: \n{4}".format(severity.title(), resource_id, resource_type, account_id, message_text),
213223
"color": color,
224+
"title": "Automated Remediation Taken",
214225
"fields": [
215226
{
216-
"title": "Automated Action",
227+
"title": "Action",
217228
"value": action,
218229
"short": "true"
219230
},
@@ -233,7 +244,7 @@ def process_remediation_event(event):
233244
"short": "true"
234245
},
235246
{
236-
"title": "Message",
247+
"title": "Details",
237248
"value": message_text
238249
},
239250
{

0 commit comments

Comments
 (0)