Not packaging for linux in 4.19

[vejay24]

Hi is the ping plugin compatible with ue4 4.19. It compiles fine for windows but not linux servers. Also I always get an error with wrong ip or ipv4 address when I try to send the ping in windows. Address without the port doesnt work and neither with the port

[metahusk]

2>Building 2 actions with 24 processes...
2>  Module.Ping.cpp
2>  In file included from /Ping/Module.Ping.cpp:3:
2>\Plugins\PingPlugin\Source\Ping\Private\MacLinuxPingThread.cpp(186,36): error : use of undeclared identifier 'ThreadComplete'
2>                  FPlatformAtomics::InterlockedAdd(ThreadComplete, -1);
2>                                                   ^
2>\Plugins\PingPlugin\Source\Ping\Private\MacLinuxPingThread.cpp(200,36): error : use of undeclared identifier 'PingTime'
2>                  FPlatformAtomics::InterlockedAdd(PingTime, FCString::Atoi(*timeResult));
2>                                                   ^
2>\Plugins\PingPlugin\Source\Ping\Private\MacLinuxPingThread.cpp(210,42): error : use of undeclared identifier 'ThreadComplete'
2>          FPlatformAtomics::InterlockedAdd(ThreadComplete, -1);
2>                                           ^
2>\Plugins\PingPlugin\Source\Ping\Private\MacLinuxPingThread.cpp(218,41): error : use of undeclared identifier 'ThreadComplete'
2>          FPlatformAtomics::InterlockedIncrement(ThreadComplete);
2>                                                 ^
2>  4 errors generated.

I'm noticing the same problem with building on Linux. I haven't tested the the Win IP results issue. My internal build from 04-06-2018 seems to work without issues on 4.20. (I believe it's the committed code from Mar 2, 2018 and before if you want to try it?)

[vejay24]

@metahusk Thanks I will try it

[Prazon]

Was this issue figured out? I still have it on my end for linux packaging

[Tolc]

@Prazon I've done some digging, fixed the issues, and made the plugin UE 4.25 ready for Windows, Linux, and Mac 😉
Take a look a my pull request! (#9)