fix: implement persistent auth session using expo-secure-store#305
fix: implement persistent auth session using expo-secure-store#305Midoriya-w wants to merge 4 commits into
Conversation
|
@ShantKhatri Could please look into this. |
Sure. |
|
Hi @Midoriya-w , allow some more time for this pr, as I need to test some other functionality and edge cases too. Thanks! |
sure take your time! |
|
Hi @Midoriya-w , we are strictyly moved from expo, and our strict policy on not using any expo deps. |
|
hey @ShantKhatri Thanks for reviewing. I understand. Since the project has moved away from Expo dependencies, I'll update the implementation to use the existing AsyncStorage solution already present in the mobile app and push the changes shortly. |
CI Results — ❌ Some checks failed
🕐 Last updated: |
|
hey @ShantKhatri Tested locally. Verified that the implementation now uses AsyncStorage instead of Expo Secure Store and the auth session persistence flow works as expected. No blocking issues found from my side. |
|
Hi @ShantKhatri, I've updated the PR to replace Expo Secure Store with AsyncStorage as requested. My branch is synced with the latest main and there are no merge conflicts locally. Could you please recheck the PR when you get a chance? Thanks! |
CI — All Checks PassedBackend — SKIP
Mobile — PASS
Web — SKIP
Last updated: |
aa2f35b to
2da8d69
Compare
|
Someone is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: dinesh <midoriya54378@gmail.com>
|
hey @ShantKhatri can you check on this pr. |
|
Changes here are not relevant to issue, so closing this PR. |
Closes #264
Changes:
expo-secure-storeuseEffect