Skip to content

fix(typecheck): address test typing issues#462

Merged
Harxhit merged 3 commits into
Dev-Card:mainfrom
Harxhit:fix/typecheck
Jun 3, 2026
Merged

fix(typecheck): address test typing issues#462
Harxhit merged 3 commits into
Dev-Card:mainfrom
Harxhit:fix/typecheck

Conversation

@Harxhit

@Harxhit Harxhit commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix TypeScript errors preventing the backend from typechecking successfully.


Type of Change

  • Bug fix
  • Tests only

What Changed

  • Fixed Prisma mock typings in backend test files to satisfy Fastify and Prisma type requirements.
  • Updated test mocks to use proper Vitest mock patterns, resolving mockResolvedValue and related typing errors.
  • Fixed validateEnv test typing issues and regenerated Prisma Client to synchronize generated types with the current schema.
  • Verified backend typecheck passes after removing unrelated upstream typecheck failures.

How to Test

  1. Run typecheck: cd apps/backend && pnpm typecheck

Checklist

  • My code follows the project's coding style (pnpm -r run lint passes).
  • TypeScript compiles without errors (pnpm -r run typecheck).
  • I have added or updated tests for the changes I made.
  • All tests pass locally (pnpm -r run test).
  • I have updated documentation where necessary.
  • No new console.log or debug statements left in the code.
  • Breaking changes are documented in this PR description.

Additional Context

This PR focuses solely on resolving backend typecheck failures and test typing issues. No functional application behavior was changed.

@Harxhit Harxhit requested a review from blankirigaya June 3, 2026 09:07
@Harxhit Harxhit added the gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. label Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

CI Results — ❌ Some checks failed

🖥️ Backend (❌ failure)

Check Status
Lint ❌ failure
Test ❌ failure
Typecheck ❌ failure

📱 Mobile (⏭️ skipped)

Check Status
Lint ⚪ unknown
Test ⚪ unknown

🌐 Web (⏭️ skipped)

Check Status
Check ⚪ unknown
Build ⚪ unknown

🕐 Last updated: Wed, 03 Jun 2026 10:26:47 GMT

@Harxhit Harxhit merged commit fcf1f2a into Dev-Card:main Jun 3, 2026
20 of 26 checks passed
@Harxhit Harxhit added level:advanced Complex contribution involving deeper technical work. (+55 pts) quality:clean PR is well-structured, readable, and follows good practices. (×1.2 multiplier) type:performance Performance optimization (+15 pts) type:refactor Code refactoring/cleanup (+10 pts) type:bug Bug fixes (+10 pts) labels Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. level:advanced Complex contribution involving deeper technical work. (+55 pts) quality:clean PR is well-structured, readable, and follows good practices. (×1.2 multiplier) type:bug Bug fixes (+10 pts) type:performance Performance optimization (+15 pts) type:refactor Code refactoring/cleanup (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants