fix: improve feature card readability and contrast (#319)#502
Open
Jai-Shankar1033 wants to merge 1 commit into
Open
fix: improve feature card readability and contrast (#319)#502Jai-Shankar1033 wants to merge 1 commit into
Jai-Shankar1033 wants to merge 1 commit into
Conversation
|
@Jai-Shankar1033 is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
CI — Checks FailedBackend — SKIP
Mobile — SKIP
Web — FAIL
Last updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the readability and accessibility of feature cards on the landing page.
Fixes low text contrast, missing base styles, and light/dark theme inconsistencies
in the new React architecture.
Closes #319
Type of Change
What Changed
position: relativeandoverflow: hiddento.feature-cardbase stylescolor: var(--text-primary)on.feature-card h3for reliable heading contrast.feature-card pwithfont-size: 0.97remandline-height: 1.75for better readability#f1f5f9, body text#cbd5e1#0f172a, body text#475569box-shadowdepth for card separation from background::beforepseudo-elementbackground 0.35s easefor smooth theme switching transitionHow to Test
cd apps/web && pnpm devand openhttp://localhost:5173Checklist
pnpm -r run lintpasses).pnpm -r run typecheck).pnpm -r run test).console.logor debug statements left in the code.Screenshots / Recordings
Additional Context
This is a re-implementation of PR #405 which was closed because the project
migrated from SvelteKit to React. All contrast ratios now meet WCAG AA/AAA
standards in both light and dark themes.