fix: resolve typecheck errors across the repository#505
Merged
Conversation
|
@Harxhit is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
CI — All Checks PassedBackend — PASS
Mobile — SKIP
Web — SKIP
Last updated: |
ShantKhatri
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolved repository typecheck issues related to card routes and services. Updated error handling in card deletion flows and aligned tests with the current service behavior to ensure consistent API responses.
Closes #
Type of Change
What Changed
src/services/cardService.tsto improve delete-card error handling and service behavior.src/routes/cards.tsto properly map service-level errors (NOT_FOUND,LAST_CARD) to HTTP responses.src/__tests__/cards.test.tsto validate the revised delete-card behavior and ensure typecheck/test compatibility.How to Test
Run
npm run typecheckand verify there are no TypeScript errors.Run
npm run test src/__tests__/cards.test.tsand verify all card route tests pass.Test card deletion scenarios:
404response.400response.204response.Checklist
console.logor debug statements left in the code.Additional Context
These changes were made as part of repository-wide typecheck cleanup and to ensure route handlers correctly translate service-layer errors into appropriate HTTP responses.