fix: remove github_follow token when disconnecting github account#529
Open
anirudhagarwal-dev wants to merge 2 commits into
Open
fix: remove github_follow token when disconnecting github account#529anirudhagarwal-dev wants to merge 2 commits into
anirudhagarwal-dev wants to merge 2 commits into
Conversation
|
@anirudhagarwal-dev is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
CI — Checks FailedBackend — FAIL
Mobile — SKIP
Web — FAIL
Last updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a bug where the
github_followOAuth token remained in the database even after a user disconnected their GitHub account. This was caused by the disconnect endpoint not recognizinggithub_followas a supported platform and only targeting the primarygithubtoken.Closes #458
Type of Change
What Changed
DELETE /api/connect/:platformroute in connect.ts to includegithub_followin the supported platforms list.github, the system now usesdeleteManyto remove both thegithub(login) andgithub_follow(follow-capable) tokens in a single operation.How to Verify
npm --prefix apps/backend run test src/__tests__/connect.test.ts