fix: Update ArgoCD notifications configuration for context variables

Author: dcasati

Act-3/argocd-notifications-config.yaml

@@ -4,13 +4,10 @@ metadata:
   name: argocd-notifications-cm
   namespace: argocd
 data:
-  # Cluster name - set this to your cluster context name
-  # You can set this automatically with: kubectl patch configmap argocd-notifications-cm -n argocd -p "{\"data\":{\"cluster-name\":\"$(kubectl config current-context)\"}}"
-  cluster-name: "CLUSTER_NAME_PLACEHOLDER"
-  
-  # Resource Group - set this from node label kubernetes.azure.com/network-resourcegroup
-  # You can set this automatically with: kubectl patch configmap argocd-notifications-cm -n argocd -p "{\"data\":{\"resource-group\":\"$(kubectl get nodes -o jsonpath='{.items[0].metadata.labels.kubernetes\.azure\.com/network-resourcegroup}')\"}}"
-  resource-group: "RESOURCE_GROUP_PLACEHOLDER"
+  # Context variables for notifications
+  context: |
+    clusterName: CLUSTER_NAME_PLACEHOLDER
+    resourceGroup: RESOURCE_GROUP_PLACEHOLDER
   
   # GitHub webhook service configuration
   service.webhook.github-webhook: |
@@ -27,12 +24,12 @@ data:
 
   # Trigger on sync failures
   trigger.on-sync-failed: |
-    - when: app.status.operationState.phase in ['Error', 'Failed']
+    - when: app.status.operationState != nil && app.status.operationState.phase in ['Error', 'Failed']
       send: [sync-failed-webhook]
 
   # Trigger on degraded health
   trigger.on-health-degraded: |
-    - when: app.status.health.status == 'Degraded'
+    - when: app.status.health != nil && app.status.health.status == 'Degraded'
       send: [sync-failed-webhook]
 
   # Template for the webhook payload
@@ -50,10 +47,9 @@ data:
               "message": "{{.app.status.operationState.message}}",
               "revision": "{{.app.status.sync.revision}}",
               "repo_url": "{{.app.spec.source.repoURL}}",
-              "cluster": "$cluster-name",
-              "resource_group": "$resource-group",
+              "cluster": "{{.context.clusterName}}",
+              "resource_group": "{{.context.resourceGroup}}",
               "namespace": "{{.app.spec.destination.namespace}}",
-              "timestamp": "{{.app.status.operationState.finishedAt}}",
               "resources": {{toJson .app.status.resources}}
             }
           }

Act-3/setup-cluster-name.sh

@@ -10,9 +10,9 @@ RESOURCE_GROUP=$(kubectl get nodes -o jsonpath='{.items[0].metadata.labels.kuber
 echo "Setting cluster name in ArgoCD notifications: $CLUSTER_NAME"
 echo "Setting resource group in ArgoCD notifications: $RESOURCE_GROUP"
 
-# Update the cluster-name and resource-group in the argocd-notifications-cm ConfigMap
+# Update the context in the argocd-notifications-cm ConfigMap
 kubectl patch configmap argocd-notifications-cm -n argocd \
-  -p "{\"data\":{\"cluster-name\":\"$CLUSTER_NAME\",\"resource-group\":\"$RESOURCE_GROUP\"}}"
+  -p "{\"data\":{\"context\":\"clusterName: $CLUSTER_NAME\\nresourceGroup: $RESOURCE_GROUP\\n\"}}"
 
 # Restart the notifications controller to pick up the change
 kubectl rollout restart deployment argocd-notifications-controller -n argocd