From 8b398d93ee2e9a37726d9ea6815fb414c2f03f5d Mon Sep 17 00:00:00 2001 From: Giles Knap Date: Tue, 13 Oct 2026 10:09:55 +0000 Subject: [PATCH] Publish the chart only when the container image was pushed The helm job waited only for test, so on a tag a failed image build still published a chart whose default image tag did not exist. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01CCtPFejfd3WP589miPqaL3 --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d0747ec..9d99496 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,11 +38,12 @@ jobs: packages: write helm: - needs: test + # The chart's default image is the one container pushes for the same tag + needs: [test, container] if: always() uses: ./.github/workflows/_helm.yml with: - publish: ${{ needs.test.result == 'success' }} + publish: ${{ needs.test.result == 'success' && needs.container.result == 'success' }} permissions: contents: read packages: write