Radient: make texture upload test waits time-based

Use a wall-clock timeout instead of a fixed retry count and avoid
busy-waiting while asynchronous texture uploads are pending.

Author: TheMostDiligent

Tests/RadientGPUTest/src/RadientAssetManagerGPUTest.cpp

@@ -51,6 +51,8 @@ using namespace std::chrono_literals;
 namespace
 {
 
+static constexpr auto TextureManagerWaitTimeout = std::chrono::seconds{10};
+
 std::vector<Uint8> MakeTexturePixels(Uint32 Width,
                                      Uint32 Height,
                                      Uint32 Stride,
@@ -105,14 +107,15 @@ bool IsPendingOrOK(RADIENT_STATUS Status)
 
 bool WaitForPendingCopyCommandEnqueueCallbacks(RadientAssetManagerImpl& AssetManager)
 {
-    for (Uint32 i = 0; i < 256; ++i)
+    const auto Deadline = std::chrono::steady_clock::now() + TextureManagerWaitTimeout;
+    do
     {
         const RadientTextureAssetManagerStats Stats = AssetManager.GetTextureManagerStats();
         if (Stats.PendingCopyCommandEnqueueCallbacks != 0)
             return true;
 
         std::this_thread::sleep_for(1ms);
-    }
+    } while (std::chrono::steady_clock::now() < Deadline);
 
     return AssetManager.GetTextureManagerStats().PendingCopyCommandEnqueueCallbacks != 0;
 }
@@ -121,7 +124,8 @@ bool WaitForTextureManagerIdle(RadientAssetManagerImpl& AssetManager,
                                IRenderDevice*           pDevice,
                                IDeviceContext*          pContext)
 {
-    for (Uint32 i = 0; i < 256; ++i)
+    const auto Deadline = std::chrono::steady_clock::now() + TextureManagerWaitTimeout;
+    do
     {
         const RadientTextureAssetManagerStats Stats = AssetManager.GetTextureManagerStats();
         if (Stats.PendingTextureLoads == 0 &&
@@ -137,11 +141,10 @@ bool WaitForTextureManagerIdle(RadientAssetManagerImpl& AssetManager,
             pContext->Flush();
             pContext->FinishFrame();
         }
-        else
-        {
-            std::this_thread::sleep_for(1ms);
-        }
-    }
+
+        // Avoid busy-waiting while asynchronous texture work is in progress.
+        std::this_thread::sleep_for(1ms);
+    } while (std::chrono::steady_clock::now() < Deadline);
 
     const RadientTextureAssetManagerStats Stats = AssetManager.GetTextureManagerStats();
     return Stats.PendingTextureLoads == 0 &&

Tests/RadientGPUTest/src/RadientGPUTestHelpers.cpp

@@ -45,9 +45,10 @@ namespace RadientGPUTest
 namespace
 {
 
-static constexpr Uint32 TestVertexPoolSize       = 1024;
-static constexpr Uint64 TestIndexBufferSize      = 1024 * 1024;
-static constexpr Uint32 TestTextureAtlasMaxSlice = 16;
+static constexpr Uint32 TestVertexPoolSize        = 1024;
+static constexpr Uint64 TestIndexBufferSize       = 1024 * 1024;
+static constexpr Uint32 TestTextureAtlasMaxSlice  = 16;
+static constexpr auto   TextureManagerWaitTimeout = std::chrono::seconds{10};
 
 Uint32 GetTextureStride(const TestTextureParams& Params)
 {
@@ -214,17 +215,19 @@ bool WaitForTextureManagerIdle(const RadientTextureAssetManagerSharedPtr& Manage
 {
     using namespace std::chrono_literals;
 
-    for (Uint32 i = 0; i < 256; ++i)
+    const auto Deadline = std::chrono::steady_clock::now() + TextureManagerWaitTimeout;
+    do
     {
         const RadientTextureAssetManagerStats Stats = Manager->GetStats();
         if (IsTextureManagerIdle(Stats))
             return true;
 
         if (Stats.PendingCopyCommandEnqueueCallbacks != 0)
             PumpUploadManager(UploadManager, Context);
-        else
-            std::this_thread::sleep_for(1ms);
-    }
+
+        // Avoid busy-waiting while asynchronous texture work is in progress.
+        std::this_thread::sleep_for(1ms);
+    } while (std::chrono::steady_clock::now() < Deadline);
 
     return IsTextureManagerIdle(Manager->GetStats());
 }
@@ -233,14 +236,15 @@ bool WaitForPendingCopyCommandEnqueueCallbacks(const RadientTextureAssetManagerS
 {
     using namespace std::chrono_literals;
 
-    for (Uint32 i = 0; i < 256; ++i)
+    const auto Deadline = std::chrono::steady_clock::now() + TextureManagerWaitTimeout;
+    do
     {
         const RadientTextureAssetManagerStats Stats = Manager->GetStats();
         if (Stats.PendingCopyCommandEnqueueCallbacks != 0)
             return true;
 
         std::this_thread::sleep_for(1ms);
-    }
+    } while (std::chrono::steady_clock::now() < Deadline);
 
     return Manager->GetStats().PendingCopyCommandEnqueueCallbacks != 0;
 }