MAX_VAULT_DURATION boundary tests

[1nonlypiece]

Description

Exact 365 days allowed; 365 days + 1 second rejected.

Requirements and context

• Pair with tests/create_vault.rs patterns

• Must be secure, tested, and documented

• Must be secure, fully tested, and documented

• Should be efficient and easy to review for auditors and integrators

Suggested execution

1. Fork the repository and create a branch: git checkout -b test/max-duration-boundary
2. Implement the changes listed below
3. Open a draft PR early for design feedback

Implement

• Implement or document per issue scope
• Add tests where behavior is normative

Tests and documentation

• Add or extend automated tests: src/lib.rs, tests/create_vault.rs
• Add or update documentation: vesting.md or README.md
• Add Rustdoc (///) on public contract APIs where applicable (NatSpec-style)
• Validate stated security assumptions explicitly in PR description

Test and commit

1. Run the full contract test suite (e.g. cargo test, Soroban local sandbox if applicable)
2. Cover edge cases called out in this issue
3. Attach test output summary and short security notes in the PR
4. Ensure minimum 95% line coverage for touched modules (cargo tarpaulin / project standard)

Example commit message

chore(soroban): test max-duration-boundary

Guidelines

Item	Target
Test coverage	≥ 95% on changed code
Documentation	Clear, versioned, matches on-chain behavior
Timeframe	96 hours from assignment

[licette32]

@licette32 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Hi! 👋 I’d like to apply for this. I’ve reviewed the requirements and I have a clear understanding of what’s needed. I’ll follow the guidelines and keep you posted. Thanks!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @licette32 to this issue.

[drips-wave]

Congratulations, @licette32! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @licette32: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been marked as completed by a Drips Wave moderator for @licette32 as part of the Stellar Wave Program's 3rd Wave 🥳

Moderator's reason: The issue was resolved and merged in PR: #214

😎 @licette32: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.