Can't figure out why my skillcalc isn't working

[soja92]

EDIT: Noob mistake fixed, see post 2.....

Hey,

I am trying to make my own skillcalc method and I keep getting an error that I can't diagnose myself.

I was getting some perl errors I could track down before, but once I "fixed" those this error shows up. My file name is calcskill_kill_points.pl and on the web admin panel the Skill Calculation field is points.

Here are the contents of calcskill_kill_points.pl:

sub calcskill_kill_points {

	my ($self,$killer,$victim,$weapon) = @_;

	my $kskill = $killer->skill || $self->{baseskill};
	my $vskill = $victim->skill || $self->{baseskill};
	
	
	my $calc = ($vskill / $kskill);
	
	if ($calc < 0.1) {
	my $kbonus = 2;
	} elsif ($calc < 0.2) {
	my $kbonus = 4;
	} elsif ($calc < 0.4) {
	my $kbonus = 6;
	} elsif ($calc < 0.6) {
	my $kbonus = 8;
	} elsif ($calc < 0.8) {
	my $kbonus = 10;
	} elsif ($calc < 1.2) {
	my $kbonus = 12;
	} elsif ($calc < 1.4) {
	my $kbonus = 14;
	} elsif ($calc < 1.6) {
	my $kbonus = 16;
	} elsif ($calc < 1.8) {
	my $kbonus = 18;
	} elsif ($calc < 2.0) {
	my $kbonus = 20;
	} elsif ($calc < 2.2) {
	my $kbonus = 22;
	} elsif ($calc > 5.0) {
	my $kbonus = 30;
	}

	my $vbonus = ($kbonus * 0.25);

	$kskill += $kbonus;

	$vskill -= $vbonus;

	$killer->skill($kskill);
	$victim->skill($vskill);
}

sub calcskill_kill_points_init {
	# $self is a reference to the current PS::Game object.
	my ($self) = @_;
}

I am not a programmer by trade so there could be something extremely simple I am missing. I did put the formula into a standalone perl file and it gave me everything I expected. Here are the contents of the standalone perl file:

#!/usr/bin/perl

$kskill = 66741;
$vskill = 1000;

$calc = ($vskill / $kskill);

print "Calc: ", $calc ;

if ($calc < 0.1) {
        $kbonus = 2;
        } elsif ($calc < 0.2) {
        $kbonus = 4;
        } elsif ($calc < 0.4) {
        $kbonus = 6;
        } elsif ($calc < 0.6) {
        $kbonus = 8;
        } elsif ($calc < 0.8) {
        $kbonus = 10;
        } elsif ($calc < 1.2) {
        $kbonus = 12;
        } elsif ($calc < 1.4) {
        $kbonus = 14;
        } elsif ($calc < 1.6) {
        $kbonus = 16;
        } elsif ($calc < 1.8) {
        $kbonus = 18;
        } elsif ($calc < 2.0) {
        $kbonus = 20;
        } elsif ($calc < 2.2) {
        $kbonus = 22;
        } elsif ($calc > 5.0) {
        $kbonus = 30;
        }

print "\n", "KBonus: ", $kbonus, "\n";

$vbonus = ($kbonus * 0.25);

print "VBonus: ", $vbonus, "\n";

Any help would be greatly appreciated, thank you!

[soja92]

Well I'm a total idiot. Fixing the indentation cleared the error. Working calcskill_kill_points.pl looks like this:

sub calcskill_kill_points {

	my ($self,$killer,$victim,$weapon) = @_;

	my $kskill = $killer->skill || $self->{baseskill};
	my $vskill = $victim->skill || $self->{baseskill};
	
	
	my $calc = ($vskill / $kskill);
	
	if ($calc < 0.1) {
		my $kbonus = 2;
	} elsif ($calc < 0.2) {
		my $kbonus = 4;
	} elsif ($calc < 0.4) {
		my $kbonus = 6;
	} elsif ($calc < 0.6) {
		my $kbonus = 8;
	} elsif ($calc < 0.8) {
		my $kbonus = 10;
	} elsif ($calc < 1.2) {
		my $kbonus = 12;
	} elsif ($calc < 1.4) {
		my $kbonus = 14;
	} elsif ($calc < 1.6) {
		my $kbonus = 16;
	} elsif ($calc < 1.8) {
		my $kbonus = 18;
	} elsif ($calc < 2.0) {
		my $kbonus = 20;
	} elsif ($calc < 2.2) {
		my $kbonus = 22;
	} elsif ($calc > 5.0) {
		my $kbonus = 30;
	}

	my $vbonus = ($kbonus * 0.25);

	$kskill += $kbonus;

	$vskill -= $vbonus;

	$killer->skill($kskill);
	$victim->skill($vskill);
}

sub calcskill_kill_points_init {
	# $self is a reference to the current PS::Game object.
	my ($self) = @_;
}

[Drek282]

Congratulations! I also appreciate you posting this here because what you've done helps me understand some things. I'm even less of a coder than you are... :)

[soja92]

Congratulations! I also appreciate you posting this here because what you've done helps me understand some things. I'm even less of a coder than you are... :)

Thanks for doing what you've done so far! I am intending on adapting PS to work with Plutonium IW5 and maybe T6 :)

Testing site: http://45.76.28.189/psycho/index.php

[Drek282]

If you have any improvements/bug fixes/ideas you can submit that don't screw up the basic functionality, feel free to submit them.