Conversation
- 修改多个文件中的音效播放调用，确保在播放自定义音效时传递相应的游戏对象引用，以改善音效的上下文关联性。
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to version v1.8.3 by fixing audio playback logic to include proper game object references. However, the version constant in the code has not been updated to match.
- Fixed audio playback by adding game object parameter to all
AudioManager.PostCustomSFX()calls - Updated CHANGELOG files with v1.8.3 release notes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| DuckovCustomModel/MonoBehaviours/ModelHandler.cs | Added gameObject parameter to PostCustomSFX calls in OnHurt, OnDeath, and PlayIdleAudio methods |
| DuckovCustomModel/HarmonyPatches/ItemDisplayPatches.cs | Added gameObject parameter to PostCustomSFX call in item inspection state change handler |
| DuckovCustomModel/HarmonyPatches/AudioManagerPatches.cs | Added gameObject parameter to PostCustomSFX calls in audio manager patches |
| CHANGELOG_EN.md | Added v1.8.3 release notes describing the audio playback fix |
| CHANGELOG.md | Added v1.8.3 release notes (Chinese version) describing the audio playback fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
更新内容
版本信息
版本号：v1.8.3
相关提交