Conversation
- 修改 ModVersion 为 1.8.6-fix1 - 修正 AnimatorParameterDriverManager 中随机整数生成的范围，确保包含最大值 - 更新 ModelParameterDriver 和 BlueprintID 组件的文档注释，增强可读性和理解性
There was a problem hiding this comment.
Pull Request Overview
This PR fixes critical bugs in the AnimatorParameterDriverManager component and updates the version to 1.8.6-fix1. The fixes address incorrect random integer range generation, wrong field references in range conversion, and improves floating-point comparison safety. Documentation enhancements provide better clarity for the BlueprintID and ModelParameterDriver components.
- Fixed random integer generation to properly include the maximum value by adding +1 to the upper bound
- Corrected copy parameter operation to use the correct destination range fields (destMin/destMax instead of valueMin/valueMax)
- Improved floating-point division by zero check using Mathf.Epsilon instead of direct zero comparison
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DuckovCustomModel/Constant.cs | Version number updated to 1.8.6-fix1 |
| DuckovCustomModel.Core/MonoBehaviours/Packages/BlueprintID.cs | Added XML documentation comments for class and field |
| DuckovCustomModel.Core/MonoBehaviours/Animators/ModelParameterDriver.cs | Added XML documentation comments for class and runtime-cached parameter fields |
| DuckovCustomModel.Core/Managers/AnimatorParameterDriverManager.cs | Fixed random integer generation logic, corrected range conversion field references, and improved float comparison |
| CHANGELOG_EN.md | Added v1.8.6-fix1 changelog entry |
| CHANGELOG.md | Added v1.8.6-fix1 changelog entry (Chinese) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复内容