Conversation
There was a problem hiding this comment.
Pull Request Overview
This release adds two new sound trigger features to the custom model system: automatic sound playback when characters take damage (trigger_on_hurt), and quality-based sound effects when searching items (search_found_item_quality_xxx). The version number is updated to 1.8.1, and the JsonSettings configuration previously in Constant.cs has been refactored to a separate class in DuckovCustomModel.Core.
Key Changes
- Added
trigger_on_hurtsound tag with event handler in ModelHandler that plays sounds when characters take damage - Added
search_found_item_quality_xxxsound tag series (9 quality levels) with item inspection tracking system in new ItemDisplayPatches class - Refactored JsonSettings from
Constant.cstoDuckovCustomModel.Core/JsonSettings.cs
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md & README_EN.md | Added documentation for new trigger_on_hurt and search_found_item_quality_xxx sound tags with usage examples |
| CHANGELOG.md & CHANGELOG_EN.md | Added v1.8.1 release notes describing the new features |
| DuckovCustomModel/Constant.cs | Updated version to 1.8.1 and removed JsonSettings (moved to Core) |
| DuckovCustomModel.Core/Data/SoundTags.cs | Added constants for new sound tags |
| DuckovCustomModel/MonoBehaviours/ModelHandler.cs | Added OnHurt event handler and subscription to OnHurtEvent |
| DuckovCustomModel/HarmonyPatches/ItemDisplayPatches.cs | New file implementing item inspection tracking and quality-based sound playback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.8.1 正式版本
新增功能
改进