Skip to content

Skipping Shipment state machine in Ship Notify #24

@jkelleyj

Description

@jkelleyj

Because the ShipstationController's shipnotify action sets the shipment state directly, the shipment handler never gets triggered by the Spree::Shipment state machine (after_ship). This means that the shipped email is never sent even if the configuration setting is set as described in the readme.

Is there a reason why this approach to "shipping" the shipment was taken instead of using the state machine? Happy to submit a PR to fix, but want to understand if there is some gotcha I'm missing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions