(Suggestion) Relax POLYGON check in _validate_aoi_wkt(self)

[msteckle]

Correct me if I'm wrong, but I think you can query CDSE using a MULTIPOLYGON, POLYGON, MULTIPOINT, POINT, etc. Specifically checking for a POLYGON in _validate_aoi_wkt() is very restrictive. For example, I just want to find the images that intersect a particular point or set of points, but phidown raises an error when I try to do this. I think CDSE will yell when it receives a geometry it doesn't like, so is the validation necessary?

Thanks!

[sirbastiano]

Ciao Morgan, thanks for the suggestion. Let me have a look at this and see what can be implemented in the next version. In the meantime, I also invite you to follow my other project that could be of help for you (https://github.com/sirbastiano/srp)

[msteckle]

Hi Roberto, sounds great, thanks for looking into it.

sarpyx looks great, especially the snap xml processing tools. For my current work, we have to download and process a lot of Sentinel imagery on our local machines, which I've wrapped around phidown (https://github.com/msteckle/sentinel-py). I'm not a software developer by trade, so your existing tools are fantastic yet easy to understand.

Thanks again.

[sirbastiano]

Hi, thanks again for you feedback. In the latest version of phidown (0.1.26), #31 introduced the change.

Consult the changelog: https://esa-philab.github.io/phidown/changelog.html

[sirbastiano]

@msteckle let me know if I can close this issue

[msteckle]

@msteckle let me know if I can close this issue

@sirbastiano My use case passed through without error, so I think it can be closed. Thanks for implementing the change.

My only other question is why not use the shapely library and wkt.loads(geom) to validate the integrity of a WKT string? Maybe also paired with shapely.is_valid and shapely.is_valid_reason? Thanks!

[sirbastiano]

@msteckle mainly a deisgn choice for keeping minimal dependencies. I could add specific validatiors of WKT strings manually. Opening an issue for that.

[sirbastiano]

Closing this issue