fix(install): check LASTEXITCODE after git commands in install.ps1#417
Open
phoenixikkifullstack wants to merge 1 commit into
Open
fix(install): check LASTEXITCODE after git commands in install.ps1#417phoenixikkifullstack wants to merge 1 commit into
phoenixikkifullstack wants to merge 1 commit into
Conversation
PowerShell's $ErrorActionPreference = 'Stop' only applies to cmdlets, not external commands like git. When git clone or git pull fails (e.g. network timeout), the script continued executing and crashed at Get-SkillNames because the repo directory didn't exist. Add explicit $LASTEXITCODE checks after all git invocations (Clone-Or-Update and Cmd-Update) to halt immediately on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PowerShell's $ErrorActionPreference = 'Stop' only applies to cmdlets, not external commands like git. When git clone or git pull fails (e.g. network timeout), the script continued executing and crashed at Get-SkillNames because the repo directory didn't exist.
Add explicit $LASTEXITCODE checks after all git invocations (Clone-Or-Update and Cmd-Update) to halt immediately on failure.
Summary
Linked issue(s)
How I tested this
install.ps1Versioning